Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Unified Diff: ios/chrome/browser/notification_promo.h

Issue 2181833003: Defer effects of HandleViewed/HandleClosed until prefs are loaded again. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@2785
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | ios/chrome/browser/notification_promo.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ios/chrome/browser/notification_promo.h
diff --git a/ios/chrome/browser/notification_promo.h b/ios/chrome/browser/notification_promo.h
index 4431974e1cc60b95707844f20e09c4ebb01b1512..b790041db95f26a521d4b28b9995d40751e069a8 100644
--- a/ios/chrome/browser/notification_promo.h
+++ b/ios/chrome/browser/notification_promo.h
@@ -57,9 +57,8 @@ class NotificationPromo {
// Mark the promo as closed when the user dismisses it.
void HandleClosed();
- // Mark the promo has having been viewed. This returns true if views
- // exceeds the maximum allowed.
- bool HandleViewed();
+ // Mark the promo has having been viewed.
+ void HandleViewed();
const std::string& promo_text() const { return promo_text_; }
PromoType promo_type() const { return promo_type_; }
« no previous file with comments | « no previous file | ios/chrome/browser/notification_promo.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698