Defer effects of HandleViewed/HandleClosed until prefs are loaded again.

ios/chrome/browser/notification_promo.cc

 // Copyright (c) 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ios/chrome/browser/notification_promo.h"
 
 #include <stddef.h>
 
 #include "base/strings/string_number_conversions.h"
 #include "base/strings/string_util.h"
@@ skipping 214 matching lines @@
 
 bool NotificationPromo::CanShow() const {
   return !closed_ && !promo_text_.empty() && !ExceedsMaxViews() &&
          !ExceedsMaxSeconds() &&
          base::Time::FromDoubleT(StartTime()) < base::Time::Now() &&
          base::Time::FromDoubleT(EndTime()) > base::Time::Now();
 }
 
 void NotificationPromo::HandleClosed() {
   if (!closed_) {
-    closed_ = true;
-    WritePrefs();
+    WritePrefs(promo_id_, first_view_time_, views_, true);
   }
 }
 
-bool NotificationPromo::HandleViewed() {
-  ++views_;
-  if (first_view_time_ == 0) {
-    first_view_time_ = base::Time::Now().ToDoubleT();
+void NotificationPromo::HandleViewed() {
+  int views = views_ + 1;
+  double first_view_time = first_view_time_;
+  if (first_view_time == 0) {
+    first_view_time = base::Time::Now().ToDoubleT();
   }
-  WritePrefs();
-  return ExceedsMaxViews() || ExceedsMaxSeconds();
+  WritePrefs(promo_id_, first_view_time, views, closed_);
 }
 
 bool NotificationPromo::ExceedsMaxViews() const {
   return (max_views_ == 0) ? false : views_ >= max_views_;
 }
 
 bool NotificationPromo::ExceedsMaxSeconds() const {
   if (max_seconds_ == 0 || first_view_time_ == 0)
     return false;
 
@@ skipping 10 matching lines @@
 
 double NotificationPromo::StartTime() const {
   return start_;
 }
 
 double NotificationPromo::EndTime() const {
   return end_;
 }
 
 }  // namespace ios