Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Issue 2181763002: Update V8 to version 5.4.246. (Closed)

Created:
4 years, 5 months ago by v8-autoroll
Modified:
4 years, 5 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update V8 to version 5.4.246. Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/61e64edd..f5146b9b Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,littledan@chromium.org,vogelheim@chromium.org Committed: https://crrev.com/27bd5a607b8dc2f0bf5aec0eaa90f5a3f5ea30b2 Cr-Commit-Position: refs/heads/master@{#407615}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
v8-autoroll
4 years, 5 months ago (2016-07-25 19:17:10 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2181763002/1
4 years, 5 months ago (2016-07-25 19:17:51 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-25 22:20:57 UTC) #4
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/27bd5a607b8dc2f0bf5aec0eaa90f5a3f5ea30b2 Cr-Commit-Position: refs/heads/master@{#407615}
4 years, 5 months ago (2016-07-25 22:22:36 UTC) #6
benwells
4 years, 5 months ago (2016-07-26 04:59:50 UTC) #7
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2182763003/ by benwells@chromium.org.

The reason for reverting is: This has introduced build errors on DrMemory. v8
change that caused this is
https://crrev.com/52f2ceb052f63324050c7a098e4398f510b54763.

For reference the errors are:
gyp: Key 'conditions' repeated at level 11 with key path
'target_defaults.conditions.6.1.target_conditions.0.1.conditions.0.1' while
reading C:\b\build\slave\drm-cr\build\src\v8\gypfiles\toolchain.gypi while
reading includes of C:\b\build\slave\drm-cr\build\src\v8\src\d8.gyp

gyp: Key 'conditions' repeated at level 11 with key path
'target_defaults.conditions.6.1.target_conditions.0.1.conditions.0.1' while
reading C:\b\build\slave\drm-cr\build\src\v8\gypfiles\toolchain.gypi while
reading includes of C:\b\build\slave\drm-cr\build\src\v8\src\v8.gyp

gyp: Key 'conditions' repeated at level 11 with key path
'target_defaults.conditions.6.1.target_conditions.0.1.conditions.0.1' while
reading C:\b\build\slave\drm-cr\build\src\v8\gypfiles\toolchain.gypi while
reading includes of C:\b\build\slave\drm-cr\build\src\v8\samples\samples.gyp
.

Powered by Google App Engine
This is Rietveld 408576698