Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Unified Diff: src/compiler/simplified-operator.h

Issue 2181743004: [turbofan] Speculative optimize number operations with no feedback. Base URL: https://chromium.googlesource.com/v8/v8.git@631318
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/compiler/simplified-operator.h
diff --git a/src/compiler/simplified-operator.h b/src/compiler/simplified-operator.h
index 030c280c769a30bba9d8aaddb8852d926b54b3c5..2a1b52aa784c5aa80b6000672ebb90329e9c1ac6 100644
--- a/src/compiler/simplified-operator.h
+++ b/src/compiler/simplified-operator.h
@@ -8,7 +8,6 @@
#include <iosfwd>
#include "src/compiler/operator.h"
-#include "src/compiler/type-hints.h"
#include "src/handles.h"
#include "src/machine-type.h"
#include "src/objects.h"
@@ -150,9 +149,15 @@ std::ostream& operator<<(std::ostream&, ElementsTransition);
ElementsTransition ElementsTransitionOf(const Operator* op) WARN_UNUSED_RESULT;
-BinaryOperationHints::Hint BinaryOperationHintOf(const Operator* op);
+// Hints for numeric operations.
+enum class NumberOperationHint : uint8_t { kNone, kSigned32, kNumberOrOddball };
-CompareOperationHints::Hint CompareOperationHintOf(const Operator* op);
+size_t hash_value(NumberOperationHint);
+
+std::ostream& operator<<(std::ostream&, NumberOperationHint);
+
+NumberOperationHint NumberOperationHintOf(const Operator* op)
+ WARN_UNUSED_RESULT;
// Interface for building simplified operators, which represent the
// medium-level operations of V8, including adding numbers, allocating objects,
@@ -234,17 +239,16 @@ class SimplifiedOperatorBuilder final : public ZoneObject {
const Operator* NumberSilenceNaN();
- const Operator* SpeculativeNumberAdd(BinaryOperationHints::Hint hint);
- const Operator* SpeculativeNumberSubtract(BinaryOperationHints::Hint hint);
- const Operator* SpeculativeNumberMultiply(BinaryOperationHints::Hint hint);
- const Operator* SpeculativeNumberDivide(BinaryOperationHints::Hint hint);
- const Operator* SpeculativeNumberModulus(BinaryOperationHints::Hint hint);
- const Operator* SpeculativeNumberShiftLeft(BinaryOperationHints::Hint hint);
-
- const Operator* SpeculativeNumberLessThan(CompareOperationHints::Hint hint);
- const Operator* SpeculativeNumberLessThanOrEqual(
- CompareOperationHints::Hint hint);
- const Operator* SpeculativeNumberEqual(CompareOperationHints::Hint hint);
+ const Operator* SpeculativeNumberAdd(NumberOperationHint hint);
+ const Operator* SpeculativeNumberSubtract(NumberOperationHint hint);
+ const Operator* SpeculativeNumberMultiply(NumberOperationHint hint);
+ const Operator* SpeculativeNumberDivide(NumberOperationHint hint);
+ const Operator* SpeculativeNumberModulus(NumberOperationHint hint);
+ const Operator* SpeculativeNumberShiftLeft(NumberOperationHint hint);
+
+ const Operator* SpeculativeNumberLessThan(NumberOperationHint hint);
+ const Operator* SpeculativeNumberLessThanOrEqual(NumberOperationHint hint);
+ const Operator* SpeculativeNumberEqual(NumberOperationHint hint);
const Operator* ReferenceEqual(Type* type);

Powered by Google App Engine
This is Rietveld 408576698