[turbofan] Speculative optimize number operations with no feedback.

src/compiler/simplified-lowering.cc

 // Copyright 2014 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/compiler/simplified-lowering.h"
 
 #include <limits>
 
 #include "src/address-map.h"
 #include "src/base/bits.h"
@@ skipping 1083 matching lines @@
     if (BothInputsAre(node, type_cache_.kAdditiveSafeIntegerOrMinusZero) &&
         truncation.IsUsedAsWord32()) {
       // safe-int + safe-int = x (truncated to int32)
       // => signed Int32Add/Sub (truncated)
       VisitWord32TruncatingBinop(node);
       if (lower()) ChangeToPureOp(node, Int32Op(node));
       return;
     }
 
     // Try to use type feedback.
-    BinaryOperationHints::Hint hint = BinaryOperationHintOf(node->op());
+    NumberOperationHint hint = NumberOperationHintOf(node->op());
+    if (hint == NumberOperationHint::kNone) {
+      // TODO(turbofan): Shall we change any deopts that are caused by this
+      // speculation to soft ones so we don't count against the deopt limit?
+      if (TypeOf(node->InputAt(0))->Maybe(Type::Signed32()) &&
+          TypeOf(node->InputAt(1))->Maybe(Type::Signed32())) {
+        hint = NumberOperationHint::kSigned32;
+      } else {
+        hint = NumberOperationHint::kNumberOrOddball;

[Jarin, 2016/07/26 09:39:21]

I doubt this helps anything - if the type cannot be Signed32, then it would have
to be some funky type to benefit (such as minus-zero or NaN or bool). Perhaps it
would be best to keep it simple and always set Signed32 here.

+      }
+    }
 
     // Handle the case when no int32 checks on inputs are necessary
     // (but an overflow check is needed on the output).
     if (BothInputsAre(node, Type::Signed32()) ||
         (BothInputsAre(node, type_cache_.kSigned32OrMinusZero) &&
          NodeProperties::GetType(node)->Is(type_cache_.kSafeInteger))) {
       // If both the inputs the feedback are int32, use the overflow op.
-      if (hint == BinaryOperationHints::kSignedSmall ||
-          hint == BinaryOperationHints::kSigned32) {
+      if (hint == NumberOperationHint::kSigned32) {
         VisitBinop(node, UseInfo::TruncatingWord32(),
                    MachineRepresentation::kWord32, Type::Signed32());
         if (lower()) ChangeToInt32OverflowOp(node);
         return;
       }
     }
 
-    if (hint == BinaryOperationHints::kSignedSmall ||
-        hint == BinaryOperationHints::kSigned32) {
+    if (hint == NumberOperationHint::kSigned32) {
       VisitBinop(node, UseInfo::CheckedSigned32AsWord32(),
                  MachineRepresentation::kWord32, Type::Signed32());
       if (lower()) ChangeToInt32OverflowOp(node);
       return;
     }
 
     // default case => Float64Add/Sub
+    DCHECK_EQ(NumberOperationHint::kNumberOrOddball, hint);
     VisitBinop(node, UseInfo::CheckedNumberOrOddballAsFloat64(),
                MachineRepresentation::kFloat64, Type::Number());
     if (lower()) {
       ChangeToPureOp(node, Float64Op(node));
     }
     return;
   }
 
   // Dispatching routine for visiting the node {node} with the usage {use}.
   // Depending on the operator, propagate new usage info to the inputs.
@@ skipping 149 matching lines @@
           if (lower()) ChangeToPureOp(node, Uint32Op(node));
           return;
         } else if (TypeOf(node->InputAt(0))->Is(Type::Signed32()) &&
                    TypeOf(node->InputAt(1))->Is(Type::Signed32())) {
           // => signed Int32Cmp
           VisitInt32Cmp(node);
           if (lower()) ChangeToPureOp(node, Int32Op(node));
           return;
         }
         // Try to use type feedback.
-        CompareOperationHints::Hint hint = CompareOperationHintOf(node->op());
+        NumberOperationHint hint = NumberOperationHintOf(node->op());
+        if (hint == NumberOperationHint::kNone) {
+          // TODO(turbofan): Shall we change any deopts that are caused by this
+          // speculation to soft ones so we don't count against the deopt limit?
+          if (TypeOf(node->InputAt(0))->Maybe(Type::Signed32()) &&
+              TypeOf(node->InputAt(1))->Maybe(Type::Signed32())) {
+            hint = NumberOperationHint::kSigned32;
+          } else {
+            hint = NumberOperationHint::kNumberOrOddball;
+          }
+        }
 
-        if (hint == CompareOperationHints::kSignedSmall) {
+        if (hint == NumberOperationHint::kSigned32) {
           VisitBinop(node, UseInfo::CheckedSigned32AsWord32(),
                      MachineRepresentation::kBit);
           if (lower()) ChangeToPureOp(node, Int32Op(node));
           return;
         }
-        DCHECK_EQ(CompareOperationHints::kNumberOrOddball, hint);
         // default case => Float64 comparison
+        DCHECK_EQ(NumberOperationHint::kNumberOrOddball, hint);
         VisitBinop(node, UseInfo::CheckedNumberOrOddballAsFloat64(),
                    MachineRepresentation::kBit);
         if (lower()) ChangeToPureOp(node, Float64Op(node));
         return;
       }
 
       case IrOpcode::kNumberAdd:
       case IrOpcode::kNumberSubtract: {
         if (BothInputsAre(node, Type::Signed32()) &&
             NodeProperties::GetType(node)->Is(Type::Signed32())) {
@@ skipping 32 matching lines @@
           // Multiply reduces to Int32Mul if the inputs are integers, and
           // (a) the output is either known to be Signed32, or
           // (b) the output is known to be Unsigned32, or
           // (c) the uses are truncating and the result is in the safe
           //     integer range.
           VisitWord32TruncatingBinop(node);
           if (lower()) ChangeToPureOp(node, Int32Op(node));
           return;
         }
         // Try to use type feedback.
-        BinaryOperationHints::Hint hint = BinaryOperationHintOf(node->op());
+        NumberOperationHint hint = NumberOperationHintOf(node->op());
+        if (hint == NumberOperationHint::kNone) {
+          // TODO(turbofan): Shall we change any deopts that are caused by this
+          // speculation to soft ones so we don't count against the deopt limit?
+          if (TypeOf(node->InputAt(0))->Maybe(Type::Signed32()) &&
+              TypeOf(node->InputAt(1))->Maybe(Type::Signed32())) {
+            hint = NumberOperationHint::kSigned32;
+          } else {
+            hint = NumberOperationHint::kNumberOrOddball;
+          }
+        }
         Type* input0_type = TypeOf(node->InputAt(0));
         Type* input1_type = TypeOf(node->InputAt(1));
 
         // Handle the case when no int32 checks on inputs are necessary
         // (but an overflow check is needed on the output).
         if (BothInputsAre(node, Type::Signed32())) {
           // If both the inputs the feedback are int32, use the overflow op.
-          if (hint == BinaryOperationHints::kSignedSmall ||
-              hint == BinaryOperationHints::kSigned32) {
+          if (hint == NumberOperationHint::kSigned32) {
             VisitBinop(node, UseInfo::TruncatingWord32(),
                        MachineRepresentation::kWord32, Type::Signed32());
             if (lower()) {
               LowerToCheckedInt32Mul(node, truncation, input0_type,
                                      input1_type);
             }
             return;
           }
         }
 
-        if (hint == BinaryOperationHints::kSignedSmall ||
-            hint == BinaryOperationHints::kSigned32) {
+        if (hint == NumberOperationHint::kSigned32) {
           VisitBinop(node, UseInfo::CheckedSigned32AsWord32(),
                      MachineRepresentation::kWord32, Type::Signed32());
           if (lower()) {
             LowerToCheckedInt32Mul(node, truncation, input0_type, input1_type);
           }
           return;
         }
 
         // Checked float64 x float64 => float64
+        DCHECK_EQ(NumberOperationHint::kNumberOrOddball, hint);
         VisitBinop(node, UseInfo::CheckedNumberOrOddballAsFloat64(),
                    MachineRepresentation::kFloat64, Type::Number());
         if (lower()) ChangeToPureOp(node, Float64Op(node));
         return;
       }
       case IrOpcode::kNumberMultiply: {
         if (BothInputsAre(node, Type::Integral32()) &&
             (NodeProperties::GetType(node)->Is(Type::Signed32()) ||
              NodeProperties::GetType(node)->Is(Type::Unsigned32()) ||
              (truncation.IsUsedAsWord32() &&
@@ skipping 36 matching lines @@
           }
           if (truncation.IsUsedAsWord32()) {
             // => signed Int32Div
             VisitWord32TruncatingBinop(node);
             if (lower()) DeferReplacement(node, lowering->Int32Div(node));
             return;
           }
         }
 
         // Try to use type feedback.
-        BinaryOperationHints::Hint hint = BinaryOperationHintOf(node->op());
+        NumberOperationHint hint = NumberOperationHintOf(node->op());
+        if (hint == NumberOperationHint::kNone) {
+          // TODO(turbofan): Shall we change any deopts that are caused by this
+          // speculation to soft ones so we don't count against the deopt limit?
+          if (TypeOf(node->InputAt(0))->Maybe(Type::Signed32()) &&
+              TypeOf(node->InputAt(1))->Maybe(Type::Signed32())) {
+            hint = NumberOperationHint::kSigned32;
+          } else {
+            hint = NumberOperationHint::kNumberOrOddball;
+          }
+        }
 
         // Handle the case when no uint32 checks on inputs are necessary
         // (but an overflow check is needed on the output).
         if (BothInputsAreUnsigned32(node)) {
-          if (hint == BinaryOperationHints::kSignedSmall ||
-              hint == BinaryOperationHints::kSigned32) {
+          if (hint == NumberOperationHint::kSigned32) {
             VisitBinop(node, UseInfo::TruncatingWord32(),
                        MachineRepresentation::kWord32, Type::Unsigned32());
             if (lower()) ChangeToUint32OverflowOp(node);
             return;
           }
         }
 
         // Handle the case when no int32 checks on inputs are necessary
         // (but an overflow check is needed on the output).
         if (BothInputsAreSigned32(node)) {
           // If both the inputs the feedback are int32, use the overflow op.
-          if (hint == BinaryOperationHints::kSignedSmall ||
-              hint == BinaryOperationHints::kSigned32) {
+          if (hint == NumberOperationHint::kSigned32) {
             VisitBinop(node, UseInfo::TruncatingWord32(),
                        MachineRepresentation::kWord32, Type::Signed32());
             if (lower()) ChangeToInt32OverflowOp(node);
             return;
           }
         }
 
-        if (hint == BinaryOperationHints::kSignedSmall ||
-            hint == BinaryOperationHints::kSigned32) {
+        if (hint == NumberOperationHint::kSigned32) {
           // If the result is truncated, we only need to check the inputs.
           if (truncation.IsUsedAsWord32()) {
             VisitBinop(node, UseInfo::CheckedSigned32AsWord32(),
                        MachineRepresentation::kWord32);
             if (lower()) DeferReplacement(node, lowering->Int32Div(node));
           } else {
             VisitBinop(node, UseInfo::CheckedSigned32AsWord32(),
                        MachineRepresentation::kWord32, Type::Signed32());
             if (lower()) ChangeToInt32OverflowOp(node);
           }
           return;
         }
 
         // default case => Float64Div
+        DCHECK_EQ(NumberOperationHint::kNumberOrOddball, hint);
         VisitBinop(node, UseInfo::CheckedNumberOrOddballAsFloat64(),
                    MachineRepresentation::kFloat64, Type::Number());
         if (lower()) ChangeToPureOp(node, Float64Op(node));
         return;
       }
       case IrOpcode::kNumberDivide: {
         if (BothInputsAreUnsigned32(node) && truncation.IsUsedAsWord32()) {
           // => unsigned Uint32Div
           VisitWord32TruncatingBinop(node);
           if (lower()) DeferReplacement(node, lowering->Uint32Div(node));
@@ skipping 49 matching lines @@
           }
           if (truncation.IsUsedAsWord32()) {
             // => signed Int32Mod
             VisitWord32TruncatingBinop(node);
             if (lower()) DeferReplacement(node, lowering->Int32Mod(node));
             return;
           }
         }
 
         // Try to use type feedback.
-        BinaryOperationHints::Hint hint = BinaryOperationHintOf(node->op());
+        NumberOperationHint hint = NumberOperationHintOf(node->op());
+        if (hint == NumberOperationHint::kNone) {
+          // TODO(turbofan): Shall we change any deopts that are caused by this
+          // speculation to soft ones so we don't count against the deopt limit?
+          if (TypeOf(node->InputAt(0))->Maybe(Type::Signed32()) &&
+              TypeOf(node->InputAt(1))->Maybe(Type::Signed32())) {
+            hint = NumberOperationHint::kSigned32;
+          } else {
+            hint = NumberOperationHint::kNumberOrOddball;
+          }
+        }
 
         // Handle the case when no uint32 checks on inputs are necessary
         // (but an overflow check is needed on the output).
         if (BothInputsAreUnsigned32(node)) {
-          if (hint == BinaryOperationHints::kSignedSmall ||
-              hint == BinaryOperationHints::kSigned32) {
+          if (hint == NumberOperationHint::kSigned32) {
             VisitBinop(node, UseInfo::TruncatingWord32(),
                        MachineRepresentation::kWord32, Type::Unsigned32());
             if (lower()) ChangeToUint32OverflowOp(node);
             return;
           }
         }
 
         // Handle the case when no int32 checks on inputs are necessary
         // (but an overflow check is needed on the output).
         if (BothInputsAre(node, Type::Signed32())) {
           // If both the inputs the feedback are int32, use the overflow op.
-          if (hint == BinaryOperationHints::kSignedSmall ||
-              hint == BinaryOperationHints::kSigned32) {
+          if (hint == NumberOperationHint::kSigned32) {
             VisitBinop(node, UseInfo::TruncatingWord32(),
                        MachineRepresentation::kWord32, Type::Signed32());
             if (lower()) ChangeToInt32OverflowOp(node);
             return;
           }
         }
 
-        if (hint == BinaryOperationHints::kSignedSmall ||
-            hint == BinaryOperationHints::kSigned32) {
+        if (hint == NumberOperationHint::kSigned32) {
           // If the result is truncated, we only need to check the inputs.
           if (truncation.IsUsedAsWord32()) {
             VisitBinop(node, UseInfo::CheckedSigned32AsWord32(),
                        MachineRepresentation::kWord32);
             if (lower()) DeferReplacement(node, lowering->Int32Mod(node));
           } else {
             VisitBinop(node, UseInfo::CheckedSigned32AsWord32(),
                        MachineRepresentation::kWord32, Type::Signed32());
             if (lower()) ChangeToInt32OverflowOp(node);
           }
           return;
         }
 
         // default case => Float64Mod
+        DCHECK_EQ(NumberOperationHint::kNumberOrOddball, hint);
         VisitBinop(node, UseInfo::CheckedNumberOrOddballAsFloat64(),
                    MachineRepresentation::kFloat64, Type::Number());
         if (lower()) ChangeToPureOp(node, Float64Op(node));
         return;
       }
       case IrOpcode::kNumberModulus: {
         if (BothInputsAreUnsigned32(node) && truncation.IsUsedAsWord32()) {
           // => unsigned Uint32Mod
           VisitWord32TruncatingBinop(node);
           if (lower()) DeferReplacement(node, lowering->Uint32Mod(node));
@@ skipping 45 matching lines @@
         if (BothInputsAre(node, Type::NumberOrOddball())) {
           Type* rhs_type = GetUpperBound(node->InputAt(1));
           VisitBinop(node, UseInfo::TruncatingWord32(),
                      UseInfo::TruncatingWord32(),
                      MachineRepresentation::kWord32);
           if (lower()) {
             lowering->DoShift(node, lowering->machine()->Word32Shl(), rhs_type);
           }
           return;
         }
-        BinaryOperationHints::Hint hint = BinaryOperationHintOf(node->op());
-        if (hint == BinaryOperationHints::kSignedSmall ||
-            hint == BinaryOperationHints::kSigned32) {
+        NumberOperationHint hint = NumberOperationHintOf(node->op());
+        if (hint == NumberOperationHint::kNone) {
+          // TODO(turbofan): Shall we change any deopts that are caused by this
+          // speculation to soft ones so we don't count against the deopt limit?
+          if (TypeOf(node->InputAt(0))->Maybe(Type::Signed32()) &&
+              TypeOf(node->InputAt(1))->Maybe(Type::Signed32())) {
+            hint = NumberOperationHint::kSigned32;
+          } else {
+            hint = NumberOperationHint::kNumberOrOddball;
+          }
+        }
+        if (hint == NumberOperationHint::kSigned32) {
           Type* rhs_type = GetUpperBound(node->InputAt(1));
           if (truncation.IsUsedAsWord32()) {
             VisitBinop(node, UseInfo::CheckedSigned32AsWord32(),
                        MachineRepresentation::kWord32);
             if (lower()) {
               lowering->DoShift(node, lowering->machine()->Word32Shl(),
                                 rhs_type);
             }
           } else {
             VisitBinop(node, UseInfo::CheckedSigned32AsWord32(),
@@ skipping 1823 matching lines @@
         isolate(), graph()->zone(), callable.descriptor(), 0, flags,
         Operator::kNoProperties);
     to_number_operator_.set(common()->Call(desc));
   }
   return to_number_operator_.get();
 }
 
 }  // namespace compiler
 }  // namespace internal
 }  // namespace v8