Fix debugger build by specifying nullptr for color space.

Fix debugger build by specifying nullptr for color space.


GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2181733002

Committed: https://skia.googlesource.com/skia/+/20a272d024572efa50afb436c4770341abe9e1c1

[chrishtr, 2016-07-25 17:39:49]

Description was changed from

==========
none

BUG=skia:
==========

to

==========
none

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2181733002
==========

[chrishtr, 2016-07-25 17:40:16]

Description was changed from

==========
none

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2181733002
==========

to

==========
Fix debugger build by specifying a default color space.


GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2181733002
==========

[chrishtr, 2016-07-25 17:42:29]

chrishtr@chromium.org changed reviewers:
+ fmalita@chromium.org

[Brian Osman, 2016-07-25 17:54:42]

brianosman@google.com changed reviewers:
+ brianosman@google.com

[Brian Osman, 2016-07-25 17:54:42]

https://codereview.chromium.org/2181733002/diff/1/debugger/QT/SkGLWidget.cpp
File debugger/QT/SkGLWidget.cpp (right):

https://codereview.chromium.org/2181733002/diff/1/debugger/QT/SkGLWidget.cpp#...
debugger/QT/SkGLWidget.cpp:67:
fGpuDevice.reset(SkGpuDevice::Make(std::move(curRenderTarget), colorSpace,
&props,
If you want to preserve the previous behavior, you should probably just pass
nullptr here. Specifying a color space will enable some newer rendering
features.

[f(malita), 2016-07-25 17:55:46]

https://codereview.chromium.org/2181733002/diff/1/debugger/QT/SkGLWidget.cpp
File debugger/QT/SkGLWidget.cpp (right):

https://codereview.chromium.org/2181733002/diff/1/debugger/QT/SkGLWidget.cpp#...
debugger/QT/SkGLWidget.cpp:67:
fGpuDevice.reset(SkGpuDevice::Make(std::move(curRenderTarget), colorSpace,
&props,
On 2016/07/25 17:54:42, Brian Osman wrote:
> If you want to preserve the previous behavior, you should probably just pass
> nullptr here. Specifying a color space will enable some newer rendering
> features.

+1

Let's just pass nullptr.

[chrishtr, 2016-07-25 17:58:08]

Description was changed from

==========
Fix debugger build by specifying a default color space.


GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2181733002
==========

to

==========
Fix debugger build by specifying nullptr for color space.


GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2181733002
==========

[chrishtr, 2016-07-25 17:58:41]

https://codereview.chromium.org/2181733002/diff/1/debugger/QT/SkGLWidget.cpp
File debugger/QT/SkGLWidget.cpp (right):

https://codereview.chromium.org/2181733002/diff/1/debugger/QT/SkGLWidget.cpp#...
debugger/QT/SkGLWidget.cpp:67:
fGpuDevice.reset(SkGpuDevice::Make(std::move(curRenderTarget), colorSpace,
&props,
On 2016/07/25 17:55:46, f(malita) wrote:
> On 2016/07/25 17:54:42, Brian Osman wrote:
> > If you want to preserve the previous behavior, you should probably just pass
> > nullptr here. Specifying a color space will enable some newer rendering
> > features.
> 
> +1
> 
> Let's just pass nullptr.

Done.

[f(malita), 2016-07-25 17:59:11]

lgtm

[chrishtr, 2016-07-25 18:02:12]

The CQ bit was checked by chrishtr@chromium.org

[commit-bot: I haz the power, 2016-07-25 18:02:20]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-25 18:21:36]

Description was changed from

==========
Fix debugger build by specifying nullptr for color space.


GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2181733002
==========

to

==========
Fix debugger build by specifying nullptr for color space.


GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2181733002

Committed:
https://skia.googlesource.com/skia/+/20a272d024572efa50afb436c4770341abe9e1c1
==========

[commit-bot: I haz the power, 2016-07-25 18:21:37]

Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/20a272d024572efa50afb436c4770341abe9e1c1