Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(282)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2181713002: DBC: More Load/Store Indexed variants, A few more math instructions. (Closed)

Created:
4 years, 5 months ago by zra
Modified:
4 years, 5 months ago
Reviewers:
Florian Schneider
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

DBC: More Load/Store Indexed variants, A few more math instructions. R=fschneider@google.com Committed: https://github.com/dart-lang/sdk/commit/d279392430f89b6d5f33f5d6ef76331634cefc88

Patch Set 1 #

Total comments: 2

Patch Set 2 : Add ShrImm and use it in Load/StoreIndexed #

Unified diffs Side-by-side diffs Delta from patch set Stats (+223 lines, -31 lines) Patch
M runtime/vm/constants_dbc.h View 1 5 chunks +30 lines, -15 lines 0 comments Download
M runtime/vm/intermediate_language_dbc.cc View 1 5 chunks +89 lines, -16 lines 0 comments Download
M runtime/vm/simulator_dbc.cc View 1 5 chunks +104 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
zra
4 years, 5 months ago (2016-07-25 16:14:37 UTC) #2
Florian Schneider
Lgtm https://codereview.chromium.org/2181713002/diff/1/runtime/vm/intermediate_language_dbc.cc File runtime/vm/intermediate_language_dbc.cc (right): https://codereview.chromium.org/2181713002/diff/1/runtime/vm/intermediate_language_dbc.cc#newcode738 runtime/vm/intermediate_language_dbc.cc:738: __ LoadConstant(result, Smi::Handle(Smi::New(3))); Since LoadIndexed operations are very ...
4 years, 5 months ago (2016-07-25 20:10:40 UTC) #3
zra
https://codereview.chromium.org/2181713002/diff/1/runtime/vm/intermediate_language_dbc.cc File runtime/vm/intermediate_language_dbc.cc (right): https://codereview.chromium.org/2181713002/diff/1/runtime/vm/intermediate_language_dbc.cc#newcode738 runtime/vm/intermediate_language_dbc.cc:738: __ LoadConstant(result, Smi::Handle(Smi::New(3))); On 2016/07/25 20:10:40, Florian Schneider wrote: ...
4 years, 5 months ago (2016-07-25 20:39:30 UTC) #4
zra
4 years, 5 months ago (2016-07-25 20:40:42 UTC) #6
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
d279392430f89b6d5f33f5d6ef76331634cefc88 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698