Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(320)

Issue 2181673002: Adding 3 attempts at starting the browser for a gpu integration test. (Closed)

Created:
4 years, 5 months ago by eyaich
Modified:
4 years, 4 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, piman+watch_chromium.org, Ken Russell (switch to Gerrit)
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Adding 3 attempts at starting the browser for a gpu integration test. BUG=628022 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Committed: https://crrev.com/ddb380f8be43fc6f1edef0ddb962403695b96370 Cr-Commit-Position: refs/heads/master@{#407847}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Changing from recursion to iteration #

Patch Set 3 : Adding unittest coverage #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -7 lines) Patch
M content/test/gpu/gpu_tests/gpu_integration_test.py View 1 1 chunk +14 lines, -5 lines 0 comments Download
M content/test/gpu/gpu_tests/gpu_integration_test_unittest.py View 1 2 5 chunks +27 lines, -2 lines 0 comments Download

Messages

Total messages: 22 (8 generated)
eyaich
4 years, 5 months ago (2016-07-25 14:24:40 UTC) #3
nednguyen
https://codereview.chromium.org/2181673002/diff/1/content/test/gpu/gpu_tests/gpu_integration_test.py File content/test/gpu/gpu_tests/gpu_integration_test.py (right): https://codereview.chromium.org/2181673002/diff/1/content/test/gpu/gpu_tests/gpu_integration_test.py#newcode50 content/test/gpu/gpu_tests/gpu_integration_test.py:50: self._RestartBrowser(reason) Can you do a for loop instead of ...
4 years, 5 months ago (2016-07-25 15:13:31 UTC) #4
eyaich
https://codereview.chromium.org/2181673002/diff/1/content/test/gpu/gpu_tests/gpu_integration_test.py File content/test/gpu/gpu_tests/gpu_integration_test.py (right): https://codereview.chromium.org/2181673002/diff/1/content/test/gpu/gpu_tests/gpu_integration_test.py#newcode50 content/test/gpu/gpu_tests/gpu_integration_test.py:50: self._RestartBrowser(reason) On 2016/07/25 15:13:31, nednguyen wrote: > Can you ...
4 years, 4 months ago (2016-07-26 13:15:33 UTC) #5
nednguyen
lgtm Can you add test coverage?
4 years, 4 months ago (2016-07-26 13:17:37 UTC) #6
eyaich
done
4 years, 4 months ago (2016-07-26 13:51:16 UTC) #7
nednguyen
lgtm
4 years, 4 months ago (2016-07-26 14:09:59 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2181673002/40001
4 years, 4 months ago (2016-07-26 14:11:07 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/225185)
4 years, 4 months ago (2016-07-26 14:16:53 UTC) #12
eyaich
Ken is out so could one of you take a look for directory ownership approval?
4 years, 4 months ago (2016-07-26 14:22:04 UTC) #14
bajones
On 2016/07/26 14:22:04, eyaich wrote: > Ken is out so could one of you take ...
4 years, 4 months ago (2016-07-26 17:49:17 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2181673002/40001
4 years, 4 months ago (2016-07-26 17:50:19 UTC) #17
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 4 months ago (2016-07-26 17:55:01 UTC) #18
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/ddb380f8be43fc6f1edef0ddb962403695b96370 Cr-Commit-Position: refs/heads/master@{#407847}
4 years, 4 months ago (2016-07-26 17:57:09 UTC) #20
Ken Russell (switch to Gerrit)
4 years, 4 months ago (2016-07-27 17:59:28 UTC) #22
Message was sent while issue was closed.
Thank you for adding this! LGTM after the fact.

Powered by Google App Engine
This is Rietveld 408576698