Issue 21816003: Text API does not behave according to specification

Issue 21816003: Text API does not behave according to specification (Closed)

Created:
7 years, 4 months ago by do-not-use

Modified:
7 years, 4 months ago

Reviewers:
haraken, tkent, arv (Not doing code reviews)

CC:
blink-reviews, dglazkov+blink, eae+blinkwatch, adamk+blink_chromium.org, do-not-use, lgombos

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Text API does not behave according to specification 1. Make Text.splitText() argument mandatory and stop throwing if the offset is negative as per the specification: http://www.w3.org/TR/2012/WD-dom-20121206/#dom-text-splittext This behavior is consistent with IE10 and Firefox. 2. Make Text.replaceWholeText() argument mandatory as per the DOM3 specification: http://www.w3.org/TR/DOM-Level-3-Core/core.html#Text3-replaceWholeText This behavior is consistent with IE10. This function is not supported by Firefox, likely because it was removed from DOM4. BUG=267509 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=155513

Patch Set 1 #

Total comments: 1

Patch Set 2 : Simplify link tag #

Patch Set 3 : Simplify link tag #

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+77 lines, -5 lines)			Patch
M	LayoutTests/fast/dom/non-numeric-values-numeric-parameters-expected.txt	View		1 chunk	+1 line, -1 line	0 comments	Download
M	LayoutTests/fast/dom/script-tests/non-numeric-values-numeric-parameters.js	View		1 chunk	+1 line, -1 line	0 comments	Download
A	LayoutTests/fast/dom/text-api-arguments.html	View	1	1 chunk	+42 lines, -0 lines	0 comments	Download
A	LayoutTests/fast/dom/text-api-arguments-expected.txt	View		1 chunk	+31 lines, -0 lines	0 comments	Download
M	Source/core/dom/Text.idl	View		1 chunk	+2 lines, -3 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

arv (Not doing code reviews)

LGTM https://codereview.chromium.org/21816003/diff/1/LayoutTests/fast/dom/text-api-arguments.html File LayoutTests/fast/dom/text-api-arguments.html (right): https://codereview.chromium.org/21816003/diff/1/LayoutTests/fast/dom/text-api-arguments.html#newcode4 LayoutTests/fast/dom/text-api-arguments.html:4: <link rel="help" href="http://www.w3.org/TR/2012/WD-dom-20121206/#text" /> <link ...> using /> ...

7 years, 4 months ago (2013-08-02 14:00:57 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@sisa.samsung.com/21816003/8001

7 years, 4 months ago (2013-08-05 05:41:23 UTC) #5

Message was sent while issue was closed.

Change committed as 155513

Expand Messages | Collapse Messages