Chromium Code Reviews| OLD | NEW |
|---|---|
| 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file | 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file |
| 2 // for details. All rights reserved. Use of this source code is governed by a | 2 // for details. All rights reserved. Use of this source code is governed by a |
| 3 // BSD-style license that can be found in the LICENSE file. | 3 // BSD-style license that can be found in the LICENSE file. |
| 4 | 4 |
| 5 #include "bin/io_buffer.h" | 5 #include "bin/io_buffer.h" |
| 6 | 6 |
| 7 | 7 |
| 8 namespace dart { | 8 namespace dart { |
| 9 namespace bin { | 9 namespace bin { |
| 10 | 10 |
| 11 Dart_Handle IOBuffer::Allocate(intptr_t size, uint8_t **buffer) { | 11 Dart_Handle IOBuffer::Allocate(intptr_t size, uint8_t **buffer) { |
| 12 uint8_t* data = Allocate(size); | 12 uint8_t* data = Allocate(size); |
| 13 Dart_Handle result = Dart_NewExternalTypedData( | 13 Dart_Handle result = Dart_NewExternalTypedData( |
| 14 Dart_TypedData_kUint8, data, size); | 14 Dart_TypedData_kUint8, data, size); |
| 15 Dart_NewWeakPersistentHandle(result, data, IOBuffer::Finalizer); | 15 Dart_NewWeakPersistentHandle(result, data, IOBuffer::Finalizer); |
| 16 | 16 |
| 17 if (Dart_IsError(result)) { | 17 if (Dart_IsError(result)) { |
| 18 Free(data); | 18 Free(data); |
| 19 Dart_PropagateError(result); | 19 Dart_PropagateError(result); |
| 20 } | 20 } |
| 21 if (buffer != NULL) { | 21 if (buffer != NULL) { |
| 22 *buffer = data; | 22 *buffer = data; |
| 23 } | 23 } |
| 24 return result; | 24 return result; |
| 25 } | 25 } |
| 26 | 26 |
| 27 | |
|
Bill Hesse
2013/08/09 15:32:23
I see why it is difficult to use Create in Allocat
| |
| 28 Dart_Handle IOBuffer::Create(uint8_t *buffer, intptr_t size) { | |
| 29 Dart_Handle result = Dart_NewExternalTypedData(Dart_TypedData_kUint8, | |
| 30 buffer, | |
| 31 size); | |
| 32 Dart_NewWeakPersistentHandle(result, buffer, IOBuffer::Finalizer); | |
| 33 if (Dart_IsError(result)) { | |
| 34 Dart_PropagateError(result); | |
| 35 } | |
| 36 return result; | |
| 37 } | |
| 38 | |
| 39 | |
| 27 uint8_t* IOBuffer::Allocate(intptr_t size) { | 40 uint8_t* IOBuffer::Allocate(intptr_t size) { |
| 28 return new uint8_t[size]; | 41 return new uint8_t[size]; |
| 29 } | 42 } |
| 30 | 43 |
| 31 } // namespace bin | 44 } // namespace bin |
| 32 } // namespace dart | 45 } // namespace dart |
| OLD | NEW |