Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 2181583002: Convert editing/inserting/insert-div-00[1-8].html to use w3c test harness (Closed)

Created:
4 years, 5 months ago by yosin_UTC9
Modified:
4 years, 5 months ago
Reviewers:
yoichio, Xiaocheng
CC:
blink-reviews, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert editing/inserting/insert-div-00[1-8].html to use w3c test harness This patch converts "editing/inserting/insert-div-00[1-8].html" to use w3c test harness and consolidates into "insert_div_with_style.html" to simplify test case for ease of maintenance with introducing "insertParagraph" command without "insertText" to verify result of "insertParagraph". Note: insert-div-001.html and insert-div-002.html are identical. Both set caret at end of text then insert a paragraph and a character. This patch is a preparation of getting rid of grammar checking feature. BUG=619452 TEST=n/a; this patch changes a test file Committed: https://crrev.com/b5ebca70047188a50411999c4ad30d827d48d21e Cr-Commit-Position: refs/heads/master@{#407422}

Patch Set 1 : 2016-07-25T14:10:59 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+156 lines, -748 lines) Patch
D third_party/WebKit/LayoutTests/editing/inserting/insert-div-001.html View 1 chunk +0 lines, -34 lines 0 comments Download
D third_party/WebKit/LayoutTests/editing/inserting/insert-div-002.html View 1 chunk +0 lines, -34 lines 0 comments Download
D third_party/WebKit/LayoutTests/editing/inserting/insert-div-003.html View 1 chunk +0 lines, -34 lines 0 comments Download
D third_party/WebKit/LayoutTests/editing/inserting/insert-div-004.html View 1 chunk +0 lines, -34 lines 0 comments Download
D third_party/WebKit/LayoutTests/editing/inserting/insert-div-005.html View 1 chunk +0 lines, -35 lines 0 comments Download
D third_party/WebKit/LayoutTests/editing/inserting/insert-div-006.html View 1 chunk +0 lines, -32 lines 0 comments Download
D third_party/WebKit/LayoutTests/editing/inserting/insert-div-007.html View 1 chunk +0 lines, -33 lines 0 comments Download
D third_party/WebKit/LayoutTests/editing/inserting/insert-div-008.html View 1 chunk +0 lines, -32 lines 0 comments Download
A third_party/WebKit/LayoutTests/editing/inserting/insert_div_with_style.html View 1 chunk +156 lines, -0 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/linux/editing/inserting/insert-div-001-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/linux/editing/inserting/insert-div-001-expected.txt View 1 chunk +0 lines, -19 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/linux/editing/inserting/insert-div-002-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/linux/editing/inserting/insert-div-002-expected.txt View 1 chunk +0 lines, -21 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/linux/editing/inserting/insert-div-003-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/linux/editing/inserting/insert-div-003-expected.txt View 1 chunk +0 lines, -22 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/linux/editing/inserting/insert-div-004-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/linux/editing/inserting/insert-div-004-expected.txt View 1 chunk +0 lines, -22 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/linux/editing/inserting/insert-div-005-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/linux/editing/inserting/insert-div-005-expected.txt View 1 chunk +0 lines, -25 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/linux/editing/inserting/insert-div-006-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/linux/editing/inserting/insert-div-006-expected.txt View 1 chunk +0 lines, -16 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/linux/editing/inserting/insert-div-007-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/linux/editing/inserting/insert-div-007-expected.txt View 1 chunk +0 lines, -19 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/linux/editing/inserting/insert-div-008-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/linux/editing/inserting/insert-div-008-expected.txt View 1 chunk +0 lines, -16 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac/editing/inserting/insert-div-001-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac/editing/inserting/insert-div-001-expected.txt View 1 chunk +0 lines, -19 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac/editing/inserting/insert-div-002-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac/editing/inserting/insert-div-002-expected.txt View 1 chunk +0 lines, -21 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac/editing/inserting/insert-div-003-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac/editing/inserting/insert-div-003-expected.txt View 1 chunk +0 lines, -22 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac/editing/inserting/insert-div-004-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac/editing/inserting/insert-div-004-expected.txt View 1 chunk +0 lines, -22 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac/editing/inserting/insert-div-005-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac/editing/inserting/insert-div-005-expected.txt View 1 chunk +0 lines, -25 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac/editing/inserting/insert-div-006-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac/editing/inserting/insert-div-006-expected.txt View 1 chunk +0 lines, -16 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac/editing/inserting/insert-div-007-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac/editing/inserting/insert-div-007-expected.txt View 1 chunk +0 lines, -19 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac/editing/inserting/insert-div-008-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac/editing/inserting/insert-div-008-expected.txt View 1 chunk +0 lines, -16 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/win/editing/inserting/insert-div-001-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/win/editing/inserting/insert-div-001-expected.txt View 1 chunk +0 lines, -19 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/win/editing/inserting/insert-div-002-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/win/editing/inserting/insert-div-002-expected.txt View 1 chunk +0 lines, -21 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/win/editing/inserting/insert-div-003-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/win/editing/inserting/insert-div-003-expected.txt View 1 chunk +0 lines, -22 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/win/editing/inserting/insert-div-004-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/win/editing/inserting/insert-div-004-expected.txt View 1 chunk +0 lines, -22 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/win/editing/inserting/insert-div-005-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/win/editing/inserting/insert-div-005-expected.txt View 1 chunk +0 lines, -25 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/win/editing/inserting/insert-div-006-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/win/editing/inserting/insert-div-006-expected.txt View 1 chunk +0 lines, -16 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/win/editing/inserting/insert-div-007-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/win/editing/inserting/insert-div-007-expected.txt View 1 chunk +0 lines, -19 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/win/editing/inserting/insert-div-008-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/win/editing/inserting/insert-div-008-expected.txt View 1 chunk +0 lines, -16 lines 0 comments Download

Messages

Total messages: 17 (9 generated)
yosin_UTC9
PTAL
4 years, 5 months ago (2016-07-25 05:38:43 UTC) #6
Xiaocheng
Shouldn't the file name use hyphens instead of underscores? Or is there a change in ...
4 years, 5 months ago (2016-07-25 05:56:57 UTC) #7
yosin_UTC9
On 2016/07/25 at 05:56:57, xiaochengh wrote: > Shouldn't the file name use hyphens instead of ...
4 years, 5 months ago (2016-07-25 06:26:09 UTC) #10
Xiaocheng
On 2016/07/25 at 06:26:09, yosin wrote: > On 2016/07/25 at 05:56:57, xiaochengh wrote: > > ...
4 years, 5 months ago (2016-07-25 06:40:46 UTC) #11
yosin_UTC9
On 2016/07/25 at 06:40:46, xiaochengh wrote: > On 2016/07/25 at 06:26:09, yosin wrote: > > ...
4 years, 5 months ago (2016-07-25 07:24:00 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2181583002/1
4 years, 5 months ago (2016-07-25 07:24:11 UTC) #14
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-25 07:28:57 UTC) #15
commit-bot: I haz the power
4 years, 5 months ago (2016-07-25 07:30:50 UTC) #17
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b5ebca70047188a50411999c4ad30d827d48d21e
Cr-Commit-Position: refs/heads/master@{#407422}

Powered by Google App Engine
This is Rietveld 408576698