Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(423)

Issue 2181573002: Clarify C++11 styleguide wording around std::to_string. (Closed)

Created:
4 years, 5 months ago by dcheng
Modified:
4 years, 4 months ago
Reviewers:
danakj, Nico, jbroman
CC:
chili, chromium-reviews, danakj+watch_chromium.org, jbroman+cpp_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Clarify C++11 styleguide wording around std::to_string. std::to_string() is technically a number to string conversion function, so clarify the wording to make it unambiguous. BUG=none Committed: https://crrev.com/2d4220aeef84c8b33fcc7640efa943c8bc9abf16 Cr-Commit-Position: refs/heads/master@{#407740}

Patch Set 1 #

Total comments: 4

Patch Set 2 : add doc link for to_string #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M styleguide/c++/c++11.html View 1 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
dcheng
https://codereview.chromium.org/2181573002/diff/1/styleguide/c++/c++11.html File styleguide/c++/c++11.html (right): https://codereview.chromium.org/2181573002/diff/1/styleguide/c++/c++11.html#newcode869 styleguide/c++/c++11.html:869: <td>String-Number Conversion Functions</td> In the standard, these are called ...
4 years, 5 months ago (2016-07-25 04:19:59 UTC) #2
chili
Thanks for making the update! https://codereview.chromium.org/2181573002/diff/1/styleguide/c++/c++11.html File styleguide/c++/c++11.html (right): https://codereview.chromium.org/2181573002/diff/1/styleguide/c++/c++11.html#newcode872 styleguide/c++/c++11.html:872: <td><a href="http://en.cppreference.com/w/cpp/string/basic_string/stol">std::stoi, std::stol, std::stoll</a>, ...
4 years, 5 months ago (2016-07-25 06:00:14 UTC) #3
dcheng
https://codereview.chromium.org/2181573002/diff/1/styleguide/c++/c++11.html File styleguide/c++/c++11.html (right): https://codereview.chromium.org/2181573002/diff/1/styleguide/c++/c++11.html#newcode872 styleguide/c++/c++11.html:872: <td><a href="http://en.cppreference.com/w/cpp/string/basic_string/stol">std::stoi, std::stol, std::stoll</a>, <a href="http://en.cppreference.com/w/cpp/string/basic_string/stoul">std::stoul, std::stoull</a>, <a href="http://en.cppreference.com/w/cpp/string/basic_string/stof">std::stof, ...
4 years, 5 months ago (2016-07-25 06:41:22 UTC) #4
jbroman
lgtm
4 years, 5 months ago (2016-07-25 14:37:54 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2181573002/20001
4 years, 4 months ago (2016-07-26 08:12:11 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-07-26 08:59:04 UTC) #8
commit-bot: I haz the power
4 years, 4 months ago (2016-07-26 09:00:24 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/2d4220aeef84c8b33fcc7640efa943c8bc9abf16
Cr-Commit-Position: refs/heads/master@{#407740}

Powered by Google App Engine
This is Rietveld 408576698