Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(641)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: content/browser/service_worker/service_worker_job_unittest.cc

Issue 2181553003: Stop passing const-reference of SWRegistration in all GetRegistrationsCallbacks. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: use std::move Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« content/browser/service_worker/service_worker_context_wrapper.cc ('K') | « content/browser/service_worker/service_worker_dispatcher_host.cc ('k') | content/browser/service_worker/service_worker_read_from_cache_job_unittest.cc » ('j') | content/browser/service_worker/service_worker_register_job.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/service_worker/service_worker_job_unittest.cc
diff --git a/content/browser/service_worker/service_worker_job_unittest.cc b/content/browser/service_worker/service_worker_job_unittest.cc
index d06955f01f65b1356778951a6f0e894523b29eed..dae4448211ce6ce1586d63b540fe7953eb6ba0de 100644
--- a/content/browser/service_worker/service_worker_job_unittest.cc
+++ b/content/browser/service_worker/service_worker_job_unittest.cc
@@ -58,7 +58,7 @@ void SaveFoundRegistrationCallback(
bool* called,
scoped_refptr<ServiceWorkerRegistration>* registration,
ServiceWorkerStatusCode status,
- const scoped_refptr<ServiceWorkerRegistration>& result) {
+ scoped_refptr<ServiceWorkerRegistration> result) {
EXPECT_EQ(expected_status, status);
*called = true;
*registration = result;
nhiroki 2016/07/25 09:15:40 std::move
horo 2016/07/25 09:32:01 Done.
« content/browser/service_worker/service_worker_context_wrapper.cc ('K') | « content/browser/service_worker/service_worker_dispatcher_host.cc ('k') | content/browser/service_worker/service_worker_read_from_cache_job_unittest.cc » ('j') | content/browser/service_worker/service_worker_register_job.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698