content/browser/background_sync/background_sync_manager_unittest.cc - Issue 2181553003: Stop passing const-reference of SWRegistration in all GetRegistrationsCallbacks.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/background_sync/background_sync_manager_unittest.cc

Issue 2181553003: Stop passing const-reference of SWRegistration in all GetRegistrationsCallbacks. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: use std::move Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/background_sync/background_sync_manager.cc ('k') | content/browser/background_sync/background_sync_service_impl_unittest.cc » ('j') | content/browser/background_sync/background_sync_service_impl_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/background_sync/background_sync_manager_unittest.cc

diff --git a/content/browser/background_sync/background_sync_manager_unittest.cc b/content/browser/background_sync/background_sync_manager_unittest.cc

index f4acfb7f31d763f2a72a828c1b075314b63acb89..e2b3c56997010ceafe165817f22940af3c437c0c 100644

--- a/content/browser/background_sync/background_sync_manager_unittest.cc

+++ b/content/browser/background_sync/background_sync_manager_unittest.cc

@@ -66,7 +66,7 @@ void RegisterServiceWorkerCallback(bool* called,

void FindServiceWorkerRegistrationCallback(

scoped_refptr<ServiceWorkerRegistration>* out_registration,

ServiceWorkerStatusCode status,

- const scoped_refptr<ServiceWorkerRegistration>& registration) {

+ scoped_refptr<ServiceWorkerRegistration> registration) {

EXPECT_EQ(SERVICE_WORKER_OK, status) << ServiceWorkerStatusToString(status);

*out_registration = registration;

nhiroki 2016/07/25 09:15:40 std::move(registration)

horo 2016/07/25 09:32:01 Done.

}