Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(124)

Unified Diff: content/browser/service_worker/service_worker_register_job.h

Issue 2181553003: Stop passing const-reference of SWRegistration in all GetRegistrationsCallbacks. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix ServiceWorkerContextCore::DidFindRegistrationForCheckHasServiceWorker() Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/service_worker/service_worker_register_job.h
diff --git a/content/browser/service_worker/service_worker_register_job.h b/content/browser/service_worker/service_worker_register_job.h
index 153203eab46d0617a6bc14a1cd71388567405758..7ec65a8bab223f24e2c3387717eb9b0865176f1c 100644
--- a/content/browser/service_worker/service_worker_register_job.h
+++ b/content/browser/service_worker/service_worker_register_job.h
@@ -96,8 +96,7 @@ class ServiceWorkerRegisterJob : public ServiceWorkerRegisterJobBase,
scoped_refptr<ServiceWorkerVersion> new_version;
};
- void set_registration(
- const scoped_refptr<ServiceWorkerRegistration>& registration);
+ void set_registration(scoped_refptr<ServiceWorkerRegistration> registration);
ServiceWorkerRegistration* registration();
void set_new_version(ServiceWorkerVersion* version);
ServiceWorkerVersion* new_version();
@@ -107,16 +106,16 @@ class ServiceWorkerRegisterJob : public ServiceWorkerRegisterJobBase,
void StartImpl();
void ContinueWithRegistration(
ServiceWorkerStatusCode status,
- const scoped_refptr<ServiceWorkerRegistration>& registration);
+ scoped_refptr<ServiceWorkerRegistration> registration);
void ContinueWithUpdate(
ServiceWorkerStatusCode status,
- const scoped_refptr<ServiceWorkerRegistration>& registration);
+ scoped_refptr<ServiceWorkerRegistration> registration);
void RegisterAndContinue();
void ContinueWithUninstallingRegistration(
- const scoped_refptr<ServiceWorkerRegistration>& existing_registration,
+ scoped_refptr<ServiceWorkerRegistration> existing_registration,
ServiceWorkerStatusCode status);
void ContinueWithRegistrationForSameScriptUrl(
- const scoped_refptr<ServiceWorkerRegistration>& existing_registration,
+ scoped_refptr<ServiceWorkerRegistration> existing_registration,
ServiceWorkerStatusCode status);
void UpdateAndContinue();
void OnStartWorkerFinished(ServiceWorkerStatusCode status);

Powered by Google App Engine
This is Rietveld 408576698