Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(136)

Side by Side Diff: content/browser/service_worker/service_worker_context_core.h

Issue 2181553003: Stop passing const-reference of SWRegistration in all GetRegistrationsCallbacks. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix ServiceWorkerContextCore::DidFindRegistrationForCheckHasServiceWorker() Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_BROWSER_SERVICE_WORKER_SERVICE_WORKER_CONTEXT_CORE_H_ 5 #ifndef CONTENT_BROWSER_SERVICE_WORKER_SERVICE_WORKER_CONTEXT_CORE_H_
6 #define CONTENT_BROWSER_SERVICE_WORKER_SERVICE_WORKER_CONTEXT_CORE_H_ 6 #define CONTENT_BROWSER_SERVICE_WORKER_SERVICE_WORKER_CONTEXT_CORE_H_
7 7
8 #include <stdint.h> 8 #include <stdint.h>
9 9
10 #include <map> 10 #include <map>
(...skipping 315 matching lines...) Expand 10 before | Expand all | Expand 10 after
326 void DidGetAllRegistrationsForUnregisterForOrigin( 326 void DidGetAllRegistrationsForUnregisterForOrigin(
327 const UnregistrationCallback& result, 327 const UnregistrationCallback& result,
328 const GURL& origin, 328 const GURL& origin,
329 ServiceWorkerStatusCode status, 329 ServiceWorkerStatusCode status,
330 const std::vector<ServiceWorkerRegistrationInfo>& registrations); 330 const std::vector<ServiceWorkerRegistrationInfo>& registrations);
331 331
332 void DidFindRegistrationForCheckHasServiceWorker( 332 void DidFindRegistrationForCheckHasServiceWorker(
333 const GURL& other_url, 333 const GURL& other_url,
334 const ServiceWorkerContext::CheckHasServiceWorkerCallback callback, 334 const ServiceWorkerContext::CheckHasServiceWorkerCallback callback,
335 ServiceWorkerStatusCode status, 335 ServiceWorkerStatusCode status,
336 const scoped_refptr<ServiceWorkerRegistration>& registration); 336 scoped_refptr<ServiceWorkerRegistration> registration);
337 void OnRegistrationFinishedForCheckHasServiceWorker( 337 void OnRegistrationFinishedForCheckHasServiceWorker(
338 const ServiceWorkerContext::CheckHasServiceWorkerCallback callback, 338 const ServiceWorkerContext::CheckHasServiceWorkerCallback callback,
339 const scoped_refptr<ServiceWorkerRegistration>& registration); 339 scoped_refptr<ServiceWorkerRegistration> registration);
340 340
341 // It's safe to store a raw pointer instead of a scoped_refptr to |wrapper_| 341 // It's safe to store a raw pointer instead of a scoped_refptr to |wrapper_|
342 // because the Wrapper::Shutdown call that hops threads to destroy |this| uses 342 // because the Wrapper::Shutdown call that hops threads to destroy |this| uses
343 // Bind() to hold a reference to |wrapper_| until |this| is fully destroyed. 343 // Bind() to hold a reference to |wrapper_| until |this| is fully destroyed.
344 ServiceWorkerContextWrapper* wrapper_; 344 ServiceWorkerContextWrapper* wrapper_;
345 std::unique_ptr<ProcessToProviderMap> providers_; 345 std::unique_ptr<ProcessToProviderMap> providers_;
346 std::unique_ptr<ProviderByClientUUIDMap> provider_by_uuid_; 346 std::unique_ptr<ProviderByClientUUIDMap> provider_by_uuid_;
347 std::unique_ptr<ServiceWorkerStorage> storage_; 347 std::unique_ptr<ServiceWorkerStorage> storage_;
348 scoped_refptr<EmbeddedWorkerRegistry> embedded_worker_registry_; 348 scoped_refptr<EmbeddedWorkerRegistry> embedded_worker_registry_;
349 std::unique_ptr<ServiceWorkerJobCoordinator> job_coordinator_; 349 std::unique_ptr<ServiceWorkerJobCoordinator> job_coordinator_;
(...skipping 18 matching lines...) Expand all
368 scoped_refptr<base::ObserverListThreadSafe<ServiceWorkerContextObserver>> 368 scoped_refptr<base::ObserverListThreadSafe<ServiceWorkerContextObserver>>
369 observer_list_; 369 observer_list_;
370 base::WeakPtrFactory<ServiceWorkerContextCore> weak_factory_; 370 base::WeakPtrFactory<ServiceWorkerContextCore> weak_factory_;
371 371
372 DISALLOW_COPY_AND_ASSIGN(ServiceWorkerContextCore); 372 DISALLOW_COPY_AND_ASSIGN(ServiceWorkerContextCore);
373 }; 373 };
374 374
375 } // namespace content 375 } // namespace content
376 376
377 #endif // CONTENT_BROWSER_SERVICE_WORKER_SERVICE_WORKER_CONTEXT_CORE_H_ 377 #endif // CONTENT_BROWSER_SERVICE_WORKER_SERVICE_WORKER_CONTEXT_CORE_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698