Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(405)

Side by Side Diff: content/browser/loader/navigation_url_loader_impl_core.h

Issue 2181553003: Stop passing const-reference of SWRegistration in all GetRegistrationsCallbacks. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix ServiceWorkerContextCore::DidFindRegistrationForCheckHasServiceWorker() Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_BROWSER_LOADER_NAVIGATION_URL_LOADER_IMPL_CORE_H_ 5 #ifndef CONTENT_BROWSER_LOADER_NAVIGATION_URL_LOADER_IMPL_CORE_H_
6 #define CONTENT_BROWSER_LOADER_NAVIGATION_URL_LOADER_IMPL_CORE_H_ 6 #define CONTENT_BROWSER_LOADER_NAVIGATION_URL_LOADER_IMPL_CORE_H_
7 7
8 #include <memory> 8 #include <memory>
9 9
10 #include "base/macros.h" 10 #include "base/macros.h"
(...skipping 56 matching lines...) Expand 10 before | Expand all | Expand 10 after
67 std::unique_ptr<NavigationData> navigation_data); 67 std::unique_ptr<NavigationData> navigation_data);
68 68
69 // Notifies |loader_| on the UI thread that the request failed. 69 // Notifies |loader_| on the UI thread that the request failed.
70 void NotifyRequestFailed(bool in_cache, int net_error); 70 void NotifyRequestFailed(bool in_cache, int net_error);
71 71
72 private: 72 private:
73 // Called when done checking whether the navigation has a ServiceWorker 73 // Called when done checking whether the navigation has a ServiceWorker
74 // registered for it. 74 // registered for it.
75 void OnServiceWorkerChecksPerformed( 75 void OnServiceWorkerChecksPerformed(
76 ServiceWorkerStatusCode status, 76 ServiceWorkerStatusCode status,
77 const scoped_refptr<ServiceWorkerRegistration>& registration); 77 scoped_refptr<ServiceWorkerRegistration> registration);
78 78
79 base::WeakPtr<NavigationURLLoaderImpl> loader_; 79 base::WeakPtr<NavigationURLLoaderImpl> loader_;
80 NavigationResourceHandler* resource_handler_; 80 NavigationResourceHandler* resource_handler_;
81 std::unique_ptr<NavigationRequestInfo> request_info_; 81 std::unique_ptr<NavigationRequestInfo> request_info_;
82 ResourceContext* resource_context_; 82 ResourceContext* resource_context_;
83 83
84 base::WeakPtrFactory<NavigationURLLoaderImplCore> factory_; 84 base::WeakPtrFactory<NavigationURLLoaderImplCore> factory_;
85 85
86 DISALLOW_COPY_AND_ASSIGN(NavigationURLLoaderImplCore); 86 DISALLOW_COPY_AND_ASSIGN(NavigationURLLoaderImplCore);
87 }; 87 };
88 88
89 } // namespace content 89 } // namespace content
90 90
91 #endif // CONTENT_BROWSER_LOADER_NAVIGATION_URL_LOADER_IMPL_CORE_H_ 91 #endif // CONTENT_BROWSER_LOADER_NAVIGATION_URL_LOADER_IMPL_CORE_H_
OLDNEW
« no previous file with comments | « content/browser/devtools/protocol/service_worker_handler.cc ('k') | content/browser/loader/navigation_url_loader_impl_core.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698