Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(386)

Unified Diff: third_party/WebKit/Tools/Scripts/webkitpy/common/net/buildbot.py

Issue 2181533002: Refactoring: Merge TryJob and Build class and move Build class to buildbot module. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Tools/Scripts/webkitpy/common/net/rietveld.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Tools/Scripts/webkitpy/common/net/buildbot.py
diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/common/net/buildbot.py b/third_party/WebKit/Tools/Scripts/webkitpy/common/net/buildbot.py
index adb9c2506e5a8736ead012f8564a14cb39c6741f..b8cbcfba2c5beaa5c1f27f66f1570536897b3482 100644
--- a/third_party/WebKit/Tools/Scripts/webkitpy/common/net/buildbot.py
+++ b/third_party/WebKit/Tools/Scripts/webkitpy/common/net/buildbot.py
@@ -26,6 +26,7 @@
# (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
# OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+import collections
import re
import urllib2
@@ -40,6 +41,16 @@ RESULTS_URL_BASE = 'https://storage.googleapis.com/chromium-layout-test-archives
_log = get_logger(__file__)
+class Build(collections.namedtuple('TryJob', ('builder_name', 'build_number'))):
+ """Represents a combination of builder and build number.
+
+ If build number is None, this represents the latest build
+ for a given builder.
+ """
+ def __new__(cls, builder_name, build_number=None):
+ return super(Build, cls).__new__(cls, builder_name, build_number)
+
+
class BuildBot(object):
"""This class represents an interface to BuildBot-related functionality.
« no previous file with comments | « no previous file | third_party/WebKit/Tools/Scripts/webkitpy/common/net/rietveld.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698