Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issue 2181533002: Refactoring: Merge TryJob and Build class and move Build class to buildbot module. (Closed)

Created:
4 years, 5 months ago by qyearsley
Modified:
4 years, 4 months ago
Reviewers:
wkorman
CC:
blink-reviews, cbentzel+watch_chromium.org, chromium-reviews, Dirk Pranke
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Refactoring: Merge TryJob and Build class and move Build class to buildbot module. Before this patch, there is a Build class in rebaseline.py (added in http://crrev.com/2164153002) and a TryJob class in rietveld.py, which serve the same function. This CL merges them together and moves them to another location. Committed: https://crrev.com/185603a218bada4705b736b903f63c0a20536e9e Cr-Commit-Position: refs/heads/master@{#407877}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -46 lines) Patch
M third_party/WebKit/Tools/Scripts/webkitpy/common/net/buildbot.py View 2 chunks +11 lines, -0 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/common/net/rietveld.py View 4 chunks +7 lines, -6 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/common/net/rietveld_unittest.py View 4 chunks +13 lines, -13 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline.py View 2 chunks +1 line, -27 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
qyearsley
4 years, 5 months ago (2016-07-25 16:12:44 UTC) #6
wkorman
lgtm
4 years, 4 months ago (2016-07-26 18:09:07 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2181533002/1
4 years, 4 months ago (2016-07-26 18:18:44 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-07-26 19:29:00 UTC) #11
commit-bot: I haz the power
4 years, 4 months ago (2016-07-26 19:30:31 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/185603a218bada4705b736b903f63c0a20536e9e
Cr-Commit-Position: refs/heads/master@{#407877}

Powered by Google App Engine
This is Rietveld 408576698