Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1030)

Unified Diff: third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.cpp

Issue 2181453002: [DevTools] Never stop in InjectedScriptSource (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.cpp
diff --git a/third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.cpp b/third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.cpp
index 2b232efc2e714be4c5e32cd5d5f063f3ff3f2cfc..806a97cdb1091025db4fde513822d1d7d297837d 100644
--- a/third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.cpp
+++ b/third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.cpp
@@ -873,9 +873,6 @@ void V8DebuggerAgentImpl::willExecuteScript(int scriptId)
// Fast return.
if (m_scheduledDebuggerStep != StepInto)
return;
- // Skip unknown scripts (e.g. InjectedScript).
- if (m_scripts.find(String16::fromInteger(scriptId)) == m_scripts.end())
- return;
schedulePauseOnNextStatementIfSteppingInto();
}
@@ -1054,6 +1051,13 @@ V8DebuggerAgentImpl::SkipPauseRequest V8DebuggerAgentImpl::didPause(v8::Local<v8
JavaScriptCallFrames callFrames = debugger().currentCallFrames(1);
JavaScriptCallFrame* topCallFrame = !callFrames.empty() ? callFrames.begin()->get() : nullptr;
+ // Skip pause in internal scripts (e.g. InjectedScriptSource.js).
+ if (topCallFrame) {
+ ScriptsMap::iterator it = m_scripts.find(String16::fromInteger(topCallFrame->sourceID()));
+ if (it != m_scripts.end() && it->second->isInternalScript())
+ return RequestStepFrame;
+ }
+
V8DebuggerAgentImpl::SkipPauseRequest result;
if (m_skipAllPauses)
result = RequestContinue;

Powered by Google App Engine
This is Rietveld 408576698