Issue 2181453002: [DevTools] Never stop in InjectedScriptSource

Issue 2181453002: [DevTools] Never stop in InjectedScriptSource (Closed)

Created:
4 years, 5 months ago by kozy

Modified:
4 years, 4 months ago

Reviewers:
dgozman

CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, sergeyv+blink_chromium.org, kozyatinskiy+blink_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

[DevTools] Never stop in InjectedScriptSource R=dgozman@chromium.org BUG=none Committed: https://crrev.com/99b36ab1ba3234cf731aa48c1cf15ac7fd140148 Cr-Commit-Position: refs/heads/master@{#407676}

Patch Set 1 #

Created: 4 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+78 lines, -15 lines)			Patch
M	third_party/WebKit/LayoutTests/http/tests/inspector/debugger-test.js	View	2 chunks	+16 lines, -0 lines	0 comments	Download
A	third_party/WebKit/LayoutTests/inspector/sources/debugger-step/debugger-step-in-ignore-injected-script.html	View	1 chunk	+38 lines, -0 lines	0 comments	Download
A	third_party/WebKit/LayoutTests/inspector/sources/debugger-step/debugger-step-in-ignore-injected-script-expected.txt	View	1 chunk	+7 lines, -0 lines	0 comments	Download
M	third_party/WebKit/LayoutTests/inspector/sources/debugger/internal-script-flag-for-injected-script.html	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	third_party/WebKit/LayoutTests/inspector/sources/debugger/internal-script-flag-for-injected-script-expected.txt	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.cpp	View	2 chunks	+7 lines, -3 lines	0 comments	Download
M	third_party/WebKit/Source/platform/v8_inspector/V8DebuggerImpl.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	third_party/WebKit/Source/platform/v8_inspector/V8DebuggerImpl.cpp	View	1 chunk	+3 lines, -5 lines	0 comments	Download
M	third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.cpp	View	2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 8 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

kozy

Please take a look. https://codereview.chromium.org/2179943002/ in cq, so it's ready for review.

4 years, 4 months ago (2016-07-25 20:45:07 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2181453002/1

4 years, 4 months ago (2016-07-25 23:12:00 UTC) #5

commit-bot: I haz the power

4 years, 4 months ago (2016-07-26 01:41:40 UTC) #8

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/99b36ab1ba3234cf731aa48c1cf15ac7fd140148
Cr-Commit-Position: refs/heads/master@{#407676}

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages