tools/perf/page_sets/key_silk_cases.py - Issue 2181413005: Turn off root scroller intervention on key_silk_cases page.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/perf/page_sets/key_silk_cases.py

Issue 2181413005: Turn off root scroller intervention on key_silk_cases page. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/perf/page_sets/key_silk_cases.py

diff --git a/tools/perf/page_sets/key_silk_cases.py b/tools/perf/page_sets/key_silk_cases.py

index f8fe4f9ff86f06c38bb2dbb7e3aca53ea9ab4fce..45b6c9b908e753941b478b998a859588008554b6 100644

--- a/tools/perf/page_sets/key_silk_cases.py

+++ b/tools/perf/page_sets/key_silk_cases.py

@@ -560,6 +560,13 @@ class Page26(KeySilkCasesPage):

action_runner.Wait(1)

def PerformPageInteractions(self, action_runner):

+ # add a touch-action: none because this page prevent defaults all

+ # touch moves

tdresser 2016/07/27 14:42:51 Comment needs capitalization/punctuation.

dtapuska 2016/07/27 14:47:21 Done.

+ action_runner.ExecuteJavaScript('''

+ var style = document.createElement("style");

+ document.head.appendChild(style);

+ style.sheet.insertRule("body { touch-action: none }", 0);

+ ''')

with action_runner.CreateGestureInteraction('ScrollAction'):

action_runner.ScrollPage(distance=5000)

« no previous file with comments | « no previous file | no next file » | no next file with comments »