Turn off root scroller intervention on key_silk_cases page.

Turn off root scroller intervention on key_silk_cases page.

The http://s.codepen.io/befamous/fullpage/pFsqb?scroll pageset
seems to call preventDefault on every touchmove so to not cause
a regression with our root scroller intervention the page really
should articulate that it needs touch-action:none.

BUG=625675
Committed: https://crrev.com/23914fdde83b0b7f763f34f00ff9fbba5d1a7611
Cr-Commit-Position: refs/heads/master@{#408154}

[dtapuska, 2016-07-27 05:39:12]

dtapuska@chromium.org changed reviewers:
+ sullivan@chromium.org, tdresser@chromium.org

[dtapuska, 2016-07-27 05:39:12]

tdresser@ this is what we talked about. Hopefully you can verify that it is what
we discussed.

sullivan@ can you stamp based on tdresser's review?

[tdresser, 2016-07-27 14:42:52]

LGTM, but make the subject a bit more clear before landing.

"Turn off root scroller intervention on key_silk_cases page" perhaps?

When I read the subject, I thought you were turning it off everywhere!

https://codereview.chromium.org/2181413005/diff/1/tools/perf/page_sets/key_si...
File tools/perf/page_sets/key_silk_cases.py (right):

https://codereview.chromium.org/2181413005/diff/1/tools/perf/page_sets/key_si...
tools/perf/page_sets/key_silk_cases.py:564: # touch moves
Comment needs capitalization/punctuation.

[dtapuska, 2016-07-27 14:44:57]

Description was changed from

==========
Turn off root scroller intervention on the page.

The http://s.codepen.io/befamous/fullpage/pFsqb?scroll pageset
seems to call preventDefault on every touchmove so to not cause
a regression with our root scroller intervention the page really
should articulate that it needs touch-action:none.

BUG=625675
==========

to

==========
Turn off root scroller intervention on key_silk_cases page.

The http://s.codepen.io/befamous/fullpage/pFsqb?scroll pageset
seems to call preventDefault on every touchmove so to not cause
a regression with our root scroller intervention the page really
should articulate that it needs touch-action:none.

BUG=625675
==========

[dtapuska, 2016-07-27 14:47:21]

https://codereview.chromium.org/2181413005/diff/1/tools/perf/page_sets/key_si...
File tools/perf/page_sets/key_silk_cases.py (right):

https://codereview.chromium.org/2181413005/diff/1/tools/perf/page_sets/key_si...
tools/perf/page_sets/key_silk_cases.py:564: # touch moves
On 2016/07/27 14:42:51, tdresser wrote:
> Comment needs capitalization/punctuation.

Done.

[sullivan, 2016-07-27 15:30:52]

lgtm

owner lgtm

[dtapuska, 2016-07-27 16:05:55]

The CQ bit was checked by dtapuska@chromium.org

[dtapuska, 2016-07-27 16:05:55]

The patchset sent to the CQ was uploaded after l-g-t-m from
tdresser@chromium.org
Link to the patchset: https://codereview.chromium.org/2181413005/#ps20001
(title: "Fix a capitalization issue")

[commit-bot: I haz the power, 2016-07-27 16:06:09]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-27 16:50:08]

Description was changed from

==========
Turn off root scroller intervention on key_silk_cases page.

The http://s.codepen.io/befamous/fullpage/pFsqb?scroll pageset
seems to call preventDefault on every touchmove so to not cause
a regression with our root scroller intervention the page really
should articulate that it needs touch-action:none.

BUG=625675
==========

to

==========
Turn off root scroller intervention on key_silk_cases page.

The http://s.codepen.io/befamous/fullpage/pFsqb?scroll pageset
seems to call preventDefault on every touchmove so to not cause
a regression with our root scroller intervention the page really
should articulate that it needs touch-action:none.

BUG=625675
==========

[commit-bot: I haz the power, 2016-07-27 16:50:08]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-07-27 16:51:52]

Description was changed from

==========
Turn off root scroller intervention on key_silk_cases page.

The http://s.codepen.io/befamous/fullpage/pFsqb?scroll pageset
seems to call preventDefault on every touchmove so to not cause
a regression with our root scroller intervention the page really
should articulate that it needs touch-action:none.

BUG=625675
==========

to

==========
Turn off root scroller intervention on key_silk_cases page.

The http://s.codepen.io/befamous/fullpage/pFsqb?scroll pageset
seems to call preventDefault on every touchmove so to not cause
a regression with our root scroller intervention the page really
should articulate that it needs touch-action:none.

BUG=625675

Committed: https://crrev.com/23914fdde83b0b7f763f34f00ff9fbba5d1a7611
Cr-Commit-Position: refs/heads/master@{#408154}
==========

[commit-bot: I haz the power, 2016-07-27 16:51:54]

Patchset 2 (id:??) landed as
https://crrev.com/23914fdde83b0b7f763f34f00ff9fbba5d1a7611
Cr-Commit-Position: refs/heads/master@{#408154}