Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(247)

Unified Diff: headless/lib/embedder_mojo_browsertest.cc

Issue 2181413002: [headless] Remove default browser context. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: More fixes Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: headless/lib/embedder_mojo_browsertest.cc
diff --git a/headless/lib/embedder_mojo_browsertest.cc b/headless/lib/embedder_mojo_browsertest.cc
index ec48d32294cfa2363b91d5d4dc8a51eeee3e575a..799b6b0fe2d2f8e00aa498cb7ff565bd0325d7ca 100644
--- a/headless/lib/embedder_mojo_browsertest.cc
+++ b/headless/lib/embedder_mojo_browsertest.cc
@@ -3,6 +3,7 @@
// found in the LICENSE file.
#include <memory>
+#include "base/optional.h"
#include "base/path_service.h"
#include "base/strings/stringprintf.h"
#include "base/threading/thread_restrictions.h"
@@ -85,28 +86,22 @@ class EmbedderMojoTest : public HeadlessBrowserTest,
.GetRawDataResource(IDR_HEADLESS_EMBEDDER_TEST_MOJOM_JS)
.as_string();
+ HeadlessBrowserContext::Builder builder =
+ browser()->CreateBrowserContextBuilder();
+ builder.AddJsMojoBindings("headless/lib/embedder_test.mojom",
+ embedder_test_mojom_js);
if (http_policy_ == HttpPolicy::ENABLE_HTTP) {
- browser_context_ =
- browser()
- ->CreateBrowserContextBuilder()
- .AddJsMojoBindings("headless/lib/embedder_test.mojom",
- embedder_test_mojom_js)
- .EnableUnsafeNetworkAccessWithMojoBindings(true)
- .Build();
- } else {
- browser_context_ =
- browser()
- ->CreateBrowserContextBuilder()
- .AddJsMojoBindings("headless/lib/embedder_test.mojom",
- embedder_test_mojom_js)
- .Build();
+ builder.EnableUnsafeNetworkAccessWithMojoBindings(true);
+ }
+ if (host_resolver_rules_) {
+ builder.SetHostResolverRules(*host_resolver_rules_);
}
+ browser_context_ = builder.Build();
+
web_contents_ =
- browser()
- ->CreateWebContentsBuilder()
+ browser_context_->CreateWebContentsBuilder()
.SetInitialURL(GURL(GetInitialUrl()))
- .SetBrowserContext(browser_context_.get())
.AddMojoService(base::Bind(&EmbedderMojoTest::CreateTestMojoService,
base::Unretained(this)))
.Build();
@@ -135,6 +130,7 @@ class EmbedderMojoTest : public HeadlessBrowserTest,
test_embedder_mojo_bindings_;
HttpPolicy http_policy_;
+ base::Optional<std::string> host_resolver_rules_;
};
class MojoBindingsTest : public EmbedderMojoTest {
@@ -182,11 +178,9 @@ class MojoBindingsReinstalledAfterNavigation : public EmbedderMojoTest {
void SetUpOnMainThread() override {
// We want to make sure bindings work across browser initiated cross-origin
// navigation, which is why we're setting up this fake tld.
- HeadlessBrowser::Options::Builder builder;
- builder.SetHostResolverRules(
+ host_resolver_rules_ =
base::StringPrintf("MAP not-an-actual-domain.tld 127.0.0.1:%d",
- embedded_test_server()->host_port_pair().port()));
- SetBrowserOptions(builder.Build());
+ embedded_test_server()->host_port_pair().port());
EmbedderMojoTest::SetUpOnMainThread();
}

Powered by Google App Engine
This is Rietveld 408576698