Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2536)

Unified Diff: headless/lib/browser/headless_browser_impl.cc

Issue 2181413002: [headless] Remove default browser context. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: More fixes Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: headless/lib/browser/headless_browser_impl.cc
diff --git a/headless/lib/browser/headless_browser_impl.cc b/headless/lib/browser/headless_browser_impl.cc
index 8c2096c4757d79191da05cc97062c4f6ea3f58fd..d46463014fb4d871f77d96dd47fecb8a30d397e6 100644
--- a/headless/lib/browser/headless_browser_impl.cc
+++ b/headless/lib/browser/headless_browser_impl.cc
@@ -4,6 +4,8 @@
#include "headless/lib/browser/headless_browser_impl.h"
+#include <string>
+#include <utility>
#include <vector>
#include "base/command_line.h"
@@ -49,42 +51,16 @@ HeadlessBrowserImpl::HeadlessBrowserImpl(
HeadlessBrowser::Options options)
: on_start_callback_(on_start_callback),
options_(std::move(options)),
- browser_main_parts_(nullptr) {
-}
+ browser_main_parts_(nullptr) {}
HeadlessBrowserImpl::~HeadlessBrowserImpl() {}
-HeadlessWebContents::Builder HeadlessBrowserImpl::CreateWebContentsBuilder() {
- DCHECK(BrowserMainThread()->BelongsToCurrentThread());
- return HeadlessWebContents::Builder(this);
-}
-
HeadlessBrowserContext::Builder
HeadlessBrowserImpl::CreateBrowserContextBuilder() {
DCHECK(BrowserMainThread()->BelongsToCurrentThread());
return HeadlessBrowserContext::Builder(this);
}
-HeadlessWebContents* HeadlessBrowserImpl::CreateWebContents(
- HeadlessWebContents::Builder* builder) {
- DCHECK(BrowserMainThread()->BelongsToCurrentThread());
- std::unique_ptr<HeadlessWebContentsImpl> headless_web_contents =
- HeadlessWebContentsImpl::Create(builder, window_tree_host_->window(),
- this);
- if (!headless_web_contents)
- return nullptr;
- return RegisterWebContents(std::move(headless_web_contents));
-}
-
-HeadlessWebContents* HeadlessBrowserImpl::CreateWebContents(
- const GURL& initial_url,
- const gfx::Size& size) {
- return CreateWebContentsBuilder()
- .SetInitialURL(initial_url)
- .SetWindowSize(size)
- .Build();
-}
-
scoped_refptr<base::SingleThreadTaskRunner>
HeadlessBrowserImpl::BrowserMainThread() const {
return content::BrowserThread::GetTaskRunnerForThread(
@@ -99,6 +75,19 @@ HeadlessBrowserImpl::BrowserFileThread() const {
void HeadlessBrowserImpl::Shutdown() {
DCHECK(BrowserMainThread()->BelongsToCurrentThread());
+
+ // DevToolsManagerDelegate owns some BrowserContexts. Tell it to delete them.
+ if (devtools_manager_delegate()) {
+ devtools_manager_delegate()->Shutdown();
+ }
+
+ // We need to close all WebContents here.
+ std::vector<HeadlessWebContents*> all_web_contents = GetAllWebContents();
+ for (HeadlessWebContents* web_contents : all_web_contents) {
+ web_contents->Close();
+ }
+ DCHECK(web_contents_map_.empty());
+
BrowserMainThread()->PostTask(FROM_HERE,
base::MessageLoop::QuitWhenIdleClosure());
}
@@ -138,6 +127,17 @@ void HeadlessBrowserImpl::RunOnStartCallback() {
on_start_callback_ = base::Callback<void(HeadlessBrowser*)>();
}
+HeadlessWebContents* HeadlessBrowserImpl::CreateWebContents(
+ HeadlessWebContents::Builder* builder) {
+ DCHECK(BrowserMainThread()->BelongsToCurrentThread());
+ std::unique_ptr<HeadlessWebContentsImpl> headless_web_contents =
+ HeadlessWebContentsImpl::Create(builder, window_tree_host_->window());
+ if (!headless_web_contents)
+ return nullptr;
+ builder->browser_context_->RegisterWebContents(headless_web_contents.get());
+ return RegisterWebContents(std::move(headless_web_contents));
+}
+
HeadlessWebContentsImpl* HeadlessBrowserImpl::RegisterWebContents(
std::unique_ptr<HeadlessWebContentsImpl> web_contents) {
DCHECK(web_contents);
@@ -154,6 +154,18 @@ void HeadlessBrowserImpl::DestroyWebContents(
web_contents_map_.erase(it);
}
+HeadlessDevToolsManagerDelegate*
+HeadlessBrowserImpl::devtools_manager_delegate() const {
+ DCHECK_CURRENTLY_ON(content::BrowserThread::UI);
+ return devtools_manager_delegate_.get();
+}
+
+void HeadlessBrowserImpl::set_devtools_manager_delegate(
+ base::WeakPtr<HeadlessDevToolsManagerDelegate> devtools_manager_delegate) {
+ DCHECK_CURRENTLY_ON(content::BrowserThread::UI);
+ devtools_manager_delegate_ = devtools_manager_delegate;
+}
+
HeadlessWebContents* HeadlessBrowserImpl::GetWebContentsForDevtoolsAgentHostId(
const std::string& devtools_agent_host_id) {
auto it = web_contents_map_.find(devtools_agent_host_id);
@@ -162,13 +174,6 @@ HeadlessWebContents* HeadlessBrowserImpl::GetWebContentsForDevtoolsAgentHostId(
return it->second.get();
}
-void HeadlessBrowserImpl::SetOptionsForTesting(
- HeadlessBrowser::Options options) {
- options_ = std::move(options);
- browser_main_parts()->default_browser_context()->SetOptionsForTesting(
- &options_);
-}
-
void RunChildProcessIfNeeded(int argc, const char** argv) {
base::CommandLine command_line(argc, argv);
if (!command_line.HasSwitch(switches::kProcessType))

Powered by Google App Engine
This is Rietveld 408576698