Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(973)

Issue 218133002: Add unistd.h include in a file using geteuid(). (Closed)

Created:
6 years, 9 months ago by Nico
Modified:
6 years, 8 months ago
Reviewers:
Mark Mentovai, awong
CC:
chromium-reviews, darin-cc_chromium.org, erikwright+watch_chromium.org, jam
Visibility:
Public.

Description

Add unistd.h include in a file using geteuid(). (Also delete two dead methods in other files.) BUG=31877 NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=260569

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -5 lines) Patch
M base/process/process_iterator_mac.cc View 1 chunk +1 line, -0 lines 0 comments Download
M ipc/ipc_sync_channel_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M sql/sqlite_features_unittest.cc View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Nico
6 years, 9 months ago (2014-03-29 03:18:58 UTC) #1
Nico
Looks like mento's ooo. awong, can you stamp this?
6 years, 8 months ago (2014-03-31 16:14:58 UTC) #2
awong
LGTM https://www.youtube.com/watch?v=nfBt3LrWbXE#t=0m30s
6 years, 8 months ago (2014-03-31 16:19:20 UTC) #3
Nico
The CQ bit was checked by thakis@chromium.org
6 years, 8 months ago (2014-03-31 16:37:07 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/218133002/1
6 years, 8 months ago (2014-03-31 16:37:40 UTC) #5
commit-bot: I haz the power
Change committed as 260569
6 years, 8 months ago (2014-03-31 16:46:59 UTC) #6
Mark Mentovai
6 years, 8 months ago (2014-04-01 14:08:31 UTC) #7
Message was sent while issue was closed.
LGTM

Powered by Google App Engine
This is Rietveld 408576698