Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 2181323002: Make some crucial Isolate functions inlineable (Closed)

Created:
4 years, 4 months ago by Camillo Bruni
Modified:
4 years, 4 months ago
Reviewers:
Jakob Kummerow
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

More inlineable Isolate functions The showed up unnaturally high while profiling DOM node creation. BUG=chromium:630217 Committed: https://crrev.com/d9ceb017cc60f8dcf609e5967e45708e97a681a9 Cr-Commit-Position: refs/heads/master@{#38068}

Patch Set 1 #

Patch Set 2 : revert overzealous inlining #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -36 lines) Patch
M src/isolate.h View 1 2 chunks +3 lines, -2 lines 0 comments Download
M src/isolate.cc View 1 13 chunks +15 lines, -27 lines 0 comments Download
M src/isolate-inl.h View 1 3 chunks +16 lines, -7 lines 0 comments Download

Messages

Total messages: 15 (8 generated)
Camillo Bruni
PTAL
4 years, 4 months ago (2016-07-26 13:23:35 UTC) #3
Jakob Kummerow
lgtm
4 years, 4 months ago (2016-07-26 14:56:54 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2181323002/1
4 years, 4 months ago (2016-07-26 14:58:29 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: v8_android_arm_compile_rel on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_android_arm_compile_rel/builds/21532) v8_linux64_avx2_rel_ng on master.tryserver.v8 (JOB_FAILED, ...
4 years, 4 months ago (2016-07-26 15:01:00 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2181323002/20001
4 years, 4 months ago (2016-07-26 17:04:02 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-07-26 17:29:42 UTC) #13
commit-bot: I haz the power
4 years, 4 months ago (2016-07-26 17:32:24 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/d9ceb017cc60f8dcf609e5967e45708e97a681a9
Cr-Commit-Position: refs/heads/master@{#38068}

Powered by Google App Engine
This is Rietveld 408576698