Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(90)

Issue 2181303002: [ic] Avoid memory wasting when allocating names table of type feedback metadata. (Closed)

Created:
4 years, 4 months ago by Igor Sheludko
Modified:
4 years, 4 months ago
Reviewers:
mvstanton
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[ic] Avoid memory wasting when allocating names table of type feedback metadata. BUG=chromium:625894 Committed: https://crrev.com/2fec36d9adba268c148c3ab28b8ab412021a82f3 Cr-Commit-Position: refs/heads/master@{#38047}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -23 lines) Patch
M src/objects.h View 1 chunk +3 lines, -3 lines 0 comments Download
M src/objects.cc View 2 chunks +16 lines, -17 lines 0 comments Download
M src/type-feedback-vector.cc View 2 chunks +8 lines, -3 lines 0 comments Download

Messages

Total messages: 21 (14 generated)
Igor Sheludko
PTAL
4 years, 4 months ago (2016-07-26 10:44:51 UTC) #5
mvstanton
Thanks for the quick look at this! LGTM.
4 years, 4 months ago (2016-07-26 10:56:18 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2181303002/1
4 years, 4 months ago (2016-07-26 10:59:16 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux64_asan_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_asan_rel_ng/builds/5640) v8_linux64_asan_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED, ...
4 years, 4 months ago (2016-07-26 11:07:48 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2181303002/1
4 years, 4 months ago (2016-07-26 11:39:43 UTC) #17
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-07-26 11:58:30 UTC) #19
commit-bot: I haz the power
4 years, 4 months ago (2016-07-26 12:01:44 UTC) #21
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2fec36d9adba268c148c3ab28b8ab412021a82f3
Cr-Commit-Position: refs/heads/master@{#38047}

Powered by Google App Engine
This is Rietveld 408576698