Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(245)

Issue 2181263002: Remove unused code from HTMLLinkElement (Closed)

Created:
4 years, 5 months ago by hayato
Modified:
4 years, 5 months ago
Reviewers:
Yoav Weiss
CC:
blink-reviews, blink-reviews-html_chromium.org, chromium-reviews, dglazkov+blink, gavinp+prerender_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove unused code from HTMLLinkElement This should be removed in https://codereview.chromium.org/242883002 BUG=357586, 630141 Committed: https://crrev.com/10f38919e18ed8fa5b4fa96834a024cfdd9a0667 Cr-Commit-Position: refs/heads/master@{#407739}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M third_party/WebKit/Source/core/html/HTMLLinkElement.cpp View 1 chunk +1 line, -2 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 14 (7 generated)
hayato
yoav@, could you check whether we can remove this? My concern is whether we can ...
4 years, 5 months ago (2016-07-26 07:43:09 UTC) #5
Yoav Weiss
On 2016/07/26 07:43:09, hayato wrote: > yoav@, could you check whether we can remove this? ...
4 years, 5 months ago (2016-07-26 08:13:13 UTC) #6
hayato
Thanks. I appreciate that. I can not think of. Now I do not have a ...
4 years, 5 months ago (2016-07-26 08:29:16 UTC) #7
Yoav Weiss
On 2016/07/26 08:29:16, hayato wrote: > Thanks. I appreciate that. I can not think of. ...
4 years, 5 months ago (2016-07-26 08:36:09 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2181263002/1
4 years, 5 months ago (2016-07-26 08:39:44 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-26 08:56:39 UTC) #12
commit-bot: I haz the power
4 years, 5 months ago (2016-07-26 08:58:16 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/10f38919e18ed8fa5b4fa96834a024cfdd9a0667
Cr-Commit-Position: refs/heads/master@{#407739}

Powered by Google App Engine
This is Rietveld 408576698