Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(263)

Issue 2181243003: [dashboard] Use "dialog-dismiss" and "dialog-confirm" w/ paper-dialogs (Closed)

Created:
4 years, 4 months ago by charliea (OOO until 10-5)
Modified:
4 years, 4 months ago
Reviewers:
sullivan
CC:
catapult-reviews_chromium.org, perf-dashboard-reviews_chromium.org
Base URL:
git@github.com:catapult-project/catapult.git@master
Target Ref:
refs/heads/master
Project:
catapult
Visibility:
Public.

Description

[dashboard] Use "dialog-dismiss" and "dialog-confirm" w/ paper-dialogs This replaces the pre-1.0 attributes, "affirmative" and "dismissive". Adding these attributes to a button within a paper-dialog makes those buttons automatically close the dialog. BUG=catapult:#2520 Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/25b9a024bb5d1a1ecb0a0b51a2e94dfbe554e2ef

Patch Set 1 : Checkpoint. #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -13 lines) Patch
M dashboard/dashboard/elements/bisect-form.html View 2 chunks +3 lines, -3 lines 0 comments Download
M dashboard/dashboard/elements/chart-tooltip.html View 1 chunk +2 lines, -2 lines 0 comments Download
M dashboard/dashboard/elements/trace-form.html View 2 chunks +3 lines, -3 lines 0 comments Download
M dashboard/dashboard/elements/triage-dialog.html View 3 chunks +5 lines, -5 lines 1 comment Download

Messages

Total messages: 11 (7 generated)
charliea (OOO until 10-5)
https://codereview.chromium.org/2181243003/diff/60001/dashboard/dashboard/elements/triage-dialog.html File dashboard/dashboard/elements/triage-dialog.html (right): https://codereview.chromium.org/2181243003/diff/60001/dashboard/dashboard/elements/triage-dialog.html#newcode94 dashboard/dashboard/elements/triage-dialog.html:94: <paper-button raised dismissive on-click="close">Close</paper-button> It's necessary to provide an ...
4 years, 4 months ago (2016-07-26 17:20:00 UTC) #6
sullivan
lgtm
4 years, 4 months ago (2016-07-26 17:29:01 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2181243003/60001
4 years, 4 months ago (2016-07-26 17:36:18 UTC) #9
commit-bot: I haz the power
4 years, 4 months ago (2016-07-26 18:09:57 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:60001) as
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...

Powered by Google App Engine
This is Rietveld 408576698