Move ThreadableLoader to Oilpan heap (2/3)

third_party/WebKit/Source/web/AssociatedURLLoader.cpp

 /*
  * Copyright (C) 2010, 2011, 2012 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 287 matching lines @@
     AssociatedURLLoader* m_parent;
 };
 
 AssociatedURLLoader::AssociatedURLLoader(WebLocalFrameImpl* frameImpl, const WebURLLoaderOptions& options)
     : m_client(nullptr)
     , m_options(options)
     , m_observer(new Observer(this, frameImpl->frame()->document()))
 {
 }
 
 AssociatedURLLoader::~AssociatedURLLoader()

[haraken, 2016/07/29 14:52:51]

Is it guaranteed that AssociatedURLLoader's destructor is not called during a
GC? If it happens, it's problematic because the destructor is touching an
on-heap object.

[yhirano, 2016/08/01 06:20:06]

As talked offline, this is not a problem because |m_loader| is retained as a
Persistent.

 {
     cancel();
 }
 
 #define STATIC_ASSERT_ENUM(a, b)                              \
     static_assert(static_cast<int>(a) == static_cast<int>(b), \
         "mismatching enum: " #a)
 
 STATIC_ASSERT_ENUM(WebURLLoaderOptions::CrossOriginRequestPolicyDeny, DenyCrossOriginRequests);
 STATIC_ASSERT_ENUM(WebURLLoaderOptions::CrossOriginRequestPolicyUseAccessControl, UseAccessControl);
@@ skipping 78 matching lines @@
 void AssociatedURLLoader::cancelLoader()
 {
     if (!m_clientAdapter)
         return;
 
     // Prevent invocation of the WebURLLoaderClient methods.
     m_clientAdapter->releaseClient();
 
     if (m_loader) {
         m_loader->cancel();
-        m_loader.reset();
+        m_loader = nullptr;
     }
     m_clientAdapter.reset();
 }
 
 void AssociatedURLLoader::setDefersLoading(bool defersLoading)
 {
     if (m_loader)
         m_loader->setDefersLoading(defersLoading);
 }
 
@@ skipping 34 matching lines @@
     // there could be a WebURLLoader instance behind the
     // DocumentThreadableLoader instance. So, for safety, we chose to just
     // crash here.
     RELEASE_ASSERT(ThreadState::current());
 
     m_observer->dispose();
     m_observer = nullptr;
 }
 
 } // namespace blink