Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(137)

Unified Diff: third_party/WebKit/Source/modules/fetch/DataConsumerTee.cpp

Issue 2181213003: Use DCHECK instead of ASSERT in DataConsumerHandle-related stuff (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@data_consumer_handle_unique_ptr
Patch Set: fix Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/fetch/DataConsumerTee.cpp
diff --git a/third_party/WebKit/Source/modules/fetch/DataConsumerTee.cpp b/third_party/WebKit/Source/modules/fetch/DataConsumerTee.cpp
index 6ec7c80dc730cf39e55af507cdd1b19282a02cf9..8b335d42f85c5b98c7573833af61f6d1e61c465a 100644
--- a/third_party/WebKit/Source/modules/fetch/DataConsumerTee.cpp
+++ b/third_party/WebKit/Source/modules/fetch/DataConsumerTee.cpp
@@ -160,8 +160,8 @@ public:
void setResult(Result r)
{
- ASSERT(r != WebDataConsumerHandle::Ok);
- ASSERT(r != WebDataConsumerHandle::ShouldWait);
+ DCHECK(r != WebDataConsumerHandle::Ok);
+ DCHECK(r != WebDataConsumerHandle::ShouldWait);
{
MutexLocker locker(m_mutex);
if (m_result != WebDataConsumerHandle::ShouldWait) {
@@ -183,7 +183,7 @@ public:
// No client is registered.
return;
}
- ASSERT(m_readerThread);
+ DCHECK(m_readerThread);
if (!m_readerThread->isCurrentThread()) {
m_readerThread->getWebTaskRunner()->postTask(BLINK_FROM_HERE, crossThreadBind(&DestinationContext::notify, wrapPassRefPtr(this)));
return;
@@ -200,14 +200,14 @@ public:
// caller.
void attachReader(WebDataConsumerHandle::Client* client)
{
- ASSERT(!m_readerThread);
- ASSERT(!m_client);
+ DCHECK(!m_readerThread);
+ DCHECK(!m_client);
m_readerThread = Platform::current()->currentThread();
m_client = client;
}
void detachReader()
{
- ASSERT(m_readerThread && m_readerThread->isCurrentThread());
+ DCHECK(m_readerThread && m_readerThread->isCurrentThread());
m_readerThread = nullptr;
m_client = nullptr;
}
@@ -217,8 +217,8 @@ public:
void consume(size_t size)
{
const auto& top = m_queue.first();
- ASSERT(m_offset <= m_offset + size);
- ASSERT(m_offset + size <= top->size());
+ DCHECK(m_offset <= m_offset + size);
+ DCHECK(m_offset + size <= top->size());
if (top->size() <= m_offset + size) {
m_offset = 0;
m_queue.removeFirst();
@@ -241,8 +241,8 @@ private:
void detach()
{
MutexLocker locker(m_mutex);
- ASSERT(!m_client);
- ASSERT(!m_readerThread);
+ DCHECK(!m_client);
+ DCHECK(!m_readerThread);
m_queue.clear();
}
@@ -354,7 +354,7 @@ public:
void didGetReadable() override
{
- ASSERT(m_reader);
+ DCHECK(m_reader);
Result r = WebDataConsumerHandle::Ok;
while (true) {
const void* buffer = nullptr;

Powered by Google App Engine
This is Rietveld 408576698