third_party/WebKit/Source/modules/fetch/CompositeDataConsumerHandle.h - Issue 2181213003: Use DCHECK instead of ASSERT in DataConsumerHandle-related stuff

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/fetch/CompositeDataConsumerHandle.h

Issue 2181213003: Use DCHECK instead of ASSERT in DataConsumerHandle-related stuff (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@data_consumer_handle_unique_ptr

Patch Set: fix Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | third_party/WebKit/Source/modules/fetch/CompositeDataConsumerHandle.cpp » ('j') | third_party/WebKit/Source/modules/fetch/CompositeDataConsumerHandle.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/fetch/CompositeDataConsumerHandle.h

diff --git a/third_party/WebKit/Source/modules/fetch/CompositeDataConsumerHandle.h b/third_party/WebKit/Source/modules/fetch/CompositeDataConsumerHandle.h

index 029b82ebe2c8338208673cb8f5f6452c61c72eec..ff34785b410f8fd65a2830423c5301c9d3a5d3f6 100644

--- a/third_party/WebKit/Source/modules/fetch/CompositeDataConsumerHandle.h

+++ b/third_party/WebKit/Source/modules/fetch/CompositeDataConsumerHandle.h

@@ -48,7 +48,7 @@ public:

template<typename T>

static std::unique_ptr<WebDataConsumerHandle> create(std::unique_ptr<WebDataConsumerHandle> handle, T* updater)

{

- ASSERT(handle);

+ DCHECK(handle);

Updater* u = nullptr;

std::unique_ptr<CompositeDataConsumerHandle> p = wrapUnique(new CompositeDataConsumerHandle(std::move(handle), &u));

*updater = u;