Revert of Remove NativeThemeWin::PaintIndirect

Revert of Remove NativeThemeWin::PaintIndirect (patchset #3 id:40001 of https://codereview.chromium.org/2090003003/ )

Reason for revert:
Directly causes crbug.com/628574, which is ship-blocking; we'll have to find another way to clean up the mess.

Original issue's description:
> Remove NativeThemeWin::PaintIndirect
>
> We don't seem to actually use this complicated codepath in practice.
>
> In particular:
>
> 1. // This block will only get hit with --enable-accelerated-drawing flag.
> That flag is obsolete, and its replacement also seems to no longer exist.
>
> 2. // Scrollbar components on Windows Classic theme (on all Windows versions)
>    // have particularly problematic alpha values, so always draw them
>    // indirectly.
> Turning on the Windows Classic theme on 64b Windows 7, I can't cause the block
> to be hit today.
>
> 3. // In addition, scrollbar thumbs and grippers for the Windows XP
>    // theme (available only on Windows XP) also need their alpha values
>    // fixed.
> We're no longer supporting XP and have been cleared to remove relevant code.
>
> Once it's gone, so are several copies of functions that paint the
> same UI element in different ways depending on whether they're drawing
> to HDC or SkCanvas: Gutter, MenuSeparator, MenuBackground, and
> MenuItemBackground.
>
> R=pkasting@chromium.org
> BUG=543755, 579196, 622692
>
> Committed: https://crrev.com/83a3c26417896b207efe22b116a03a9a162c0ca5
> Cr-Commit-Position: refs/heads/master@{#404155}

TBR=pkasting@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=543755, 579196, 622692
Committed: https://crrev.com/3d5fd19c90eb5e1715cd553b4161dc24d093eb23
Cr-Commit-Position: refs/heads/master@{#407679}

[tomhudson, 2016-07-26 00:28:55]

The CQ bit was checked by tomhudson@google.com

[tomhudson, 2016-07-26 00:28:55]

Created Revert of Remove NativeThemeWin::PaintIndirect

[commit-bot: I haz the power, 2016-07-26 00:29:33]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-26 00:29:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-26 00:29:35]

No L-G-T-M from a valid reviewer yet. 
CQ run can only be started by full committers or once the patch has
received an L-G-T-M from a full committer.
Even if an L-G-T-M may have been provided, it was from a non-committer,
_not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.

[tomhudson, 2016-07-26 00:31:28]

Does my LGTM suffice?

[tomhudson, 2016-07-26 00:31:36]

The CQ bit was checked by tomhudson@google.com

[commit-bot: I haz the power, 2016-07-26 00:33:10]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-26 00:33:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-26 00:33:12]

No L-G-T-M from a valid reviewer yet. 
CQ run can only be started by full committers or once the patch has
received an L-G-T-M from a full committer.
Even if an L-G-T-M may have been provided, it was from a non-committer,
_not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.

[Tom Hudson, 2016-07-26 00:57:44]

tomhudson@chromium.org changed reviewers:
+ tomhudson@chromium.org

[Tom Hudson, 2016-07-26 00:57:44]

LGTM from the chromium account this time.

[Tom Hudson, 2016-07-26 00:57:49]

The CQ bit was checked by tomhudson@chromium.org

[commit-bot: I haz the power, 2016-07-26 00:58:13]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Peter Kasting, 2016-07-26 01:07:02]

LGTM

[commit-bot: I haz the power, 2016-07-26 01:42:30]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-07-26 01:43:58]

Description was changed from

==========
Revert of Remove NativeThemeWin::PaintIndirect (patchset #3 id:40001 of
https://codereview.chromium.org/2090003003/ )

Reason for revert:
Directly causes crbug.com/628574, which is ship-blocking; we'll have to find
another way to clean up the mess.

Original issue's description:
> Remove NativeThemeWin::PaintIndirect
> 
> We don't seem to actually use this complicated codepath in practice.
> 
> In particular:
> 
> 1. // This block will only get hit with --enable-accelerated-drawing flag.
> That flag is obsolete, and its replacement also seems to no longer exist.
> 
> 2. // Scrollbar components on Windows Classic theme (on all Windows versions)
>    // have particularly problematic alpha values, so always draw them
>    // indirectly.
> Turning on the Windows Classic theme on 64b Windows 7, I can't cause the block
> to be hit today.
> 
> 3. // In addition, scrollbar thumbs and grippers for the Windows XP
>    // theme (available only on Windows XP) also need their alpha values
>    // fixed.
> We're no longer supporting XP and have been cleared to remove relevant code.
> 
> Once it's gone, so are several copies of functions that paint the
> same UI element in different ways depending on whether they're drawing
> to HDC or SkCanvas: Gutter, MenuSeparator, MenuBackground, and
> MenuItemBackground.
> 
> R=pkasting@chromium.org
> BUG=543755,579196,622692
> 
> Committed: https://crrev.com/83a3c26417896b207efe22b116a03a9a162c0ca5
> Cr-Commit-Position: refs/heads/master@{#404155}

TBR=pkasting@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=543755,579196,622692
==========

to

==========
Revert of Remove NativeThemeWin::PaintIndirect (patchset #3 id:40001 of
https://codereview.chromium.org/2090003003/ )

Reason for revert:
Directly causes crbug.com/628574, which is ship-blocking; we'll have to find
another way to clean up the mess.

Original issue's description:
> Remove NativeThemeWin::PaintIndirect
>
> We don't seem to actually use this complicated codepath in practice.
>
> In particular:
>
> 1. // This block will only get hit with --enable-accelerated-drawing flag.
> That flag is obsolete, and its replacement also seems to no longer exist.
>
> 2. // Scrollbar components on Windows Classic theme (on all Windows versions)
>    // have particularly problematic alpha values, so always draw them
>    // indirectly.
> Turning on the Windows Classic theme on 64b Windows 7, I can't cause the block
> to be hit today.
>
> 3. // In addition, scrollbar thumbs and grippers for the Windows XP
>    // theme (available only on Windows XP) also need their alpha values
>    // fixed.
> We're no longer supporting XP and have been cleared to remove relevant code.
>
> Once it's gone, so are several copies of functions that paint the
> same UI element in different ways depending on whether they're drawing
> to HDC or SkCanvas: Gutter, MenuSeparator, MenuBackground, and
> MenuItemBackground.
>
> R=pkasting@chromium.org
> BUG=543755,579196,622692
>
> Committed: https://crrev.com/83a3c26417896b207efe22b116a03a9a162c0ca5
> Cr-Commit-Position: refs/heads/master@{#404155}

TBR=pkasting@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=543755,579196,622692

Committed: https://crrev.com/3d5fd19c90eb5e1715cd553b4161dc24d093eb23
Cr-Commit-Position: refs/heads/master@{#407679}
==========

[commit-bot: I haz the power, 2016-07-26 01:43:59]

Patchset 1 (id:??) landed as
https://crrev.com/3d5fd19c90eb5e1715cd553b4161dc24d093eb23
Cr-Commit-Position: refs/heads/master@{#407679}