Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Side by Side Diff: third_party/WebKit/Source/devtools/front_end/sdk/RuntimeModel.js

Issue 2181123002: DevTools: Remove unused parameters to TextPrompt._loadCompletions callback (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Remove toLowerCase() Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2012 Google Inc. All rights reserved. 2 * Copyright (C) 2012 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 579 matching lines...) Expand 10 before | Expand all | Expand 10 after
590 if (returnByValue) 590 if (returnByValue)
591 callback(null, !!wasThrown, wasThrown ? null : result, exception Details); 591 callback(null, !!wasThrown, wasThrown ? null : result, exception Details);
592 else 592 else
593 callback(this.runtimeModel.createRemoteObject(result), !!wasThro wn, undefined, exceptionDetails); 593 callback(this.runtimeModel.createRemoteObject(result), !!wasThro wn, undefined, exceptionDetails);
594 } 594 }
595 this.target().runtimeAgent().evaluate(expression, objectGroup, includeCo mmandLineAPI, doNotPauseOnExceptionsAndMuteConsole, this.id, returnByValue, gene ratePreview, userGesture, evalCallback.bind(this)); 595 this.target().runtimeAgent().evaluate(expression, objectGroup, includeCo mmandLineAPI, doNotPauseOnExceptionsAndMuteConsole, this.id, returnByValue, gene ratePreview, userGesture, evalCallback.bind(this));
596 }, 596 },
597 597
598 /** 598 /**
599 * @param {string} expressionString 599 * @param {string} expressionString
600 * @param {string} text
601 * @param {number} cursorOffset
602 * @param {string} prefix 600 * @param {string} prefix
603 * @param {boolean} force 601 * @param {boolean} force
604 * @param {function(!Array.<string>, number=)} completionsReadyCallback 602 * @param {function(!Array.<string>, number=)} completionsReadyCallback
605 */ 603 */
606 completionsForExpression: function(expressionString, text, cursorOffset, pre fix, force, completionsReadyCallback) 604 completionsForExpression: function(expressionString, prefix, force, completi onsReadyCallback)
607 { 605 {
608 var lastIndex = expressionString.length - 1; 606 var lastIndex = expressionString.length - 1;
609 607
610 var dotNotation = (expressionString[lastIndex] === "."); 608 var dotNotation = (expressionString[lastIndex] === ".");
611 var bracketNotation = (expressionString[lastIndex] === "["); 609 var bracketNotation = (expressionString[lastIndex] === "[");
612 610
613 if (dotNotation || bracketNotation) 611 if (dotNotation || bracketNotation)
614 expressionString = expressionString.substr(0, lastIndex); 612 expressionString = expressionString.substr(0, lastIndex);
615 613
616 if (expressionString && !isNaN(expressionString)) { 614 if (expressionString && !isNaN(expressionString)) {
(...skipping 393 matching lines...) Expand 10 before | Expand all | Expand 10 after
1010 /** 1008 /**
1011 * @return {boolean} 1009 * @return {boolean}
1012 */ 1010 */
1013 isNormalListenerType: function() 1011 isNormalListenerType: function()
1014 { 1012 {
1015 return this._listenerType === "normal"; 1013 return this._listenerType === "normal";
1016 }, 1014 },
1017 1015
1018 __proto__: WebInspector.SDKObject.prototype 1016 __proto__: WebInspector.SDKObject.prototype
1019 } 1017 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698