Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Side by Side Diff: third_party/WebKit/Source/devtools/front_end/elements/StylesSidebarPane.js

Issue 2181123002: DevTools: Remove unused parameters to TextPrompt._loadCompletions callback (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Remove toLowerCase() Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2007 Apple Inc. All rights reserved. 2 * Copyright (C) 2007 Apple Inc. All rights reserved.
3 * Copyright (C) 2009 Joseph Pecoraro 3 * Copyright (C) 2009 Joseph Pecoraro
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions 6 * modification, are permitted provided that the following conditions
7 * are met: 7 * are met:
8 * 8 *
9 * 1. Redistributions of source code must retain the above copyright 9 * 1. Redistributions of source code must retain the above copyright
10 * notice, this list of conditions and the following disclaimer. 10 * notice, this list of conditions and the following disclaimer.
(...skipping 2914 matching lines...) Expand 10 before | Expand all | Expand 10 after
2925 _isValueSuggestion: function(word) 2925 _isValueSuggestion: function(word)
2926 { 2926 {
2927 if (!word) 2927 if (!word)
2928 return false; 2928 return false;
2929 word = word.toLowerCase(); 2929 word = word.toLowerCase();
2930 return this._cssCompletions.keySet().hasOwnProperty(word); 2930 return this._cssCompletions.keySet().hasOwnProperty(word);
2931 }, 2931 },
2932 2932
2933 /** 2933 /**
2934 * @param {!Element} proxyElement 2934 * @param {!Element} proxyElement
2935 * @param {string} text
2936 * @param {number} cursorOffset
2937 * @param {!Range} wordRange 2935 * @param {!Range} wordRange
2938 * @param {boolean} force 2936 * @param {boolean} force
2939 * @param {function(!Array.<string>, number=)} completionsReadyCallback 2937 * @param {function(!Array.<string>, number=)} completionsReadyCallback
2940 */ 2938 */
2941 _buildPropertyCompletions: function(proxyElement, text, cursorOffset, wordRa nge, force, completionsReadyCallback) 2939 _buildPropertyCompletions: function(proxyElement, wordRange, force, completi onsReadyCallback)
2942 { 2940 {
2943 var prefix = wordRange.toString().toLowerCase(); 2941 var prefix = wordRange.toString().toLowerCase();
2944 if (!prefix && !force && (this._isEditingName || proxyElement.textConten t.length)) { 2942 if (!prefix && !force && (this._isEditingName || proxyElement.textConten t.length)) {
2945 completionsReadyCallback([]); 2943 completionsReadyCallback([]);
2946 return; 2944 return;
2947 } 2945 }
2948 2946
2949 var results = this._cssCompletions.startsWith(prefix); 2947 var results = this._cssCompletions.startsWith(prefix);
2950 if (!this._isEditingName && !results.length && prefix.length > 1 && "!im portant".startsWith(prefix)) 2948 if (!this._isEditingName && !results.length && prefix.length > 1 && "!im portant".startsWith(prefix))
2951 results.push("!important"); 2949 results.push("!important");
(...skipping 159 matching lines...) Expand 10 before | Expand all | Expand 10 after
3111 3109
3112 /** 3110 /**
3113 * @override 3111 * @override
3114 * @return {!WebInspector.ToolbarItem} 3112 * @return {!WebInspector.ToolbarItem}
3115 */ 3113 */
3116 item: function() 3114 item: function()
3117 { 3115 {
3118 return this._button; 3116 return this._button;
3119 } 3117 }
3120 } 3118 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698