Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issue 2181113003: Convert editing/pasteboard/merge-end-blockquote.html to use w3c test harness (Closed)

Created:
4 years, 4 months ago by yosin_UTC9
Modified:
4 years, 4 months ago
Reviewers:
yoichio, Xiaocheng
CC:
blink-reviews, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert editing/pasteboard/merge-end-blockquote.html to use w3c test harness This patch converts "editing/pasteboard/merge-end-blockquote.html" to use w3c test harness to simplify test files. This patch is a preparation of getting rid of grammar checking feature. BUG=619452 TEST=n/a; this patch changes a test file Committed: https://crrev.com/5e7cb1df177023ec21114c253c2516e1ff341c10 Cr-Commit-Position: refs/heads/master@{#407760}

Patch Set 1 : 2016-07-26T16:32:33 #

Patch Set 2 : 2016-07-26T18:15:54 #

Messages

Total messages: 18 (11 generated)
yosin_UTC9
PTAL
4 years, 4 months ago (2016-07-26 08:27:01 UTC) #5
Xiaocheng
Shouldn't there be two tests, since the original test file contains two tests?
4 years, 4 months ago (2016-07-26 08:40:10 UTC) #8
yosin_UTC9
On 2016/07/26 at 08:40:10, xiaochengh wrote: > Shouldn't there be two tests, since the original ...
4 years, 4 months ago (2016-07-26 09:17:51 UTC) #11
Xiaocheng
lgtm
4 years, 4 months ago (2016-07-26 09:21:50 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2181113003/20001
4 years, 4 months ago (2016-07-26 09:23:48 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-07-26 10:29:34 UTC) #16
commit-bot: I haz the power
4 years, 4 months ago (2016-07-26 10:31:27 UTC) #18
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/5e7cb1df177023ec21114c253c2516e1ff341c10
Cr-Commit-Position: refs/heads/master@{#407760}

Powered by Google App Engine
This is Rietveld 408576698