Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(475)

Issue 2181113002: [Mac/GN] Unconditionally write the stamp file in clean_up_old_versions.py. (Closed)

Created:
4 years, 4 months ago by Robert Sesek
Modified:
4 years, 4 months ago
Reviewers:
Mark Mentovai
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Mac/GN] Unconditionally write the stamp file in clean_up_old_versions.py. Short circuiting in 342dc8a7ccd4 skipped writing the stamp file if no work was to be done. TBR=mark@chromium.org Committed: https://chromium.googlesource.com/chromium/src/+/f44c68c71cf249e905707f3ec00deaf866358f9a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -6 lines) Patch
M chrome/tools/build/mac/clean_up_old_versions.py View 1 chunk +4 lines, -6 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Robert Sesek
4 years, 4 months ago (2016-07-25 22:52:21 UTC) #1
Mark Mentovai
lgtm
4 years, 4 months ago (2016-07-25 22:55:49 UTC) #2
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/f44c68c71cf249e905707f3ec00deaf866358f9a Cr-Commit-Position: refs/heads/master@{#407621}
4 years, 4 months ago (2016-07-25 22:58:06 UTC) #4
Robert Sesek
4 years, 4 months ago (2016-07-25 22:59:23 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
f44c68c71cf249e905707f3ec00deaf866358f9a (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698