FrameFetchContext: add clear comments how FrameLoadTypeReloadMainResource works

third_party/WebKit/Source/core/loader/FrameFetchContext.cpp

Index: third_party/WebKit/Source/core/loader/FrameFetchContext.cpp
diff --git a/third_party/WebKit/Source/core/loader/FrameFetchContext.cpp b/third_party/WebKit/Source/core/loader/FrameFetchContext.cpp
index f873f582a862959088feae2731098e1add6b3b7e..030872726741a1f3137aa2e0d656d17452d2cec4 100644
--- a/third_party/WebKit/Source/core/loader/FrameFetchContext.cpp
+++ b/third_party/WebKit/Source/core/loader/FrameFetchContext.cpp
@@ -218,6 +218,10 @@ CachePolicy FrameFetchContext::getCachePolicy() const
 
     if (m_documentLoader && m_documentLoader->request().getCachePolicy() == WebCachePolicy::ReturnCacheDataElseLoad)
         return CachePolicyHistoryBuffer;
+
+    // Returns CachePolicyVerify for other cases, mainly FrameLoadTypeStandard
+    // and FrameLoadTypeReloadMainResource. See public/web/WebFrameLoadType.h
+    // to know how these load types work.
     return CachePolicyVerify;
 }
 
@@ -257,6 +261,9 @@ WebCachePolicy FrameFetchContext::resourceRequestCachePolicy(const ResourceReque
             if (frameLoadType == FrameLoadTypeReload)
                 return WebCachePolicy::ValidatingCacheData;
         }
+        // Returns UseProtocolCachePolicy for other cases, mainly
+        // FrameLoadTypeStandard and FrameLoadTypeReloadMainResource.

[hiroshige, 2016/07/28 03:38:45]

Is it referring to |frameLoadType| assigned at Line 256, not that assigned at
Line 245?
(For FrameLoadTypeReloadMainResource assigned at Line 245, ValidatingCacheData
is returned at Line 251, not at Line 267.)

[Takashi Toyoshima, 2016/07/29 13:24:49]

Ah, right.
This is confusing. Can I stop reusing the same variable for parent frame's load
type? That makes this comment understandable too.

+        // See public/web/WebFrameLoadType.h to know how these load types work.
         return WebCachePolicy::UseProtocolCachePolicy;
     }