Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(107)

Issue 2181093003: Revert of [debugging] print ranges for consecutive values with %DebugPrint (Closed)

Created:
4 years, 4 months ago by Camillo Bruni
Modified:
4 years, 4 months ago
Reviewers:
Yang
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [debugging] print ranges for consecutive values with %DebugPrint (patchset #2 id:20001 of https://codereview.chromium.org/2169143003/ ) Reason for revert: breaks android build due to uninitialized variable. https://build.chromium.org/p/client.v8.ports/builders/V8%20Arm%20-%20debug%20builder/builds/2034 Original issue's description: > [debugging] print ranges for consecutive values with %DebugPrint > > With this CL repeated values in elements are combined into a single printout with a range. > > BEFORE: > - elements = { > 0: <undefined> > 1: <undefined> > 2: <the_hole> > } > > AFTER: > - elements = { > 0-1: <undefined> > 2: <the_hole> > } > > BUG= > > Committed: https://crrev.com/ec4165742088043d8fede38db21a281e16682adb > Cr-Commit-Position: refs/heads/master@{#38069} TBR=yangguo@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Committed: https://crrev.com/7b2cd8b988d257f22afc7c03cd2caf8ba2e2b3a3 Cr-Commit-Position: refs/heads/master@{#38071}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -68 lines) Patch
M src/objects-printer.cc View 4 chunks +39 lines, -68 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Camillo Bruni
Created Revert of [debugging] print ranges for consecutive values with %DebugPrint
4 years, 4 months ago (2016-07-26 18:53:12 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2181093003/1
4 years, 4 months ago (2016-07-26 18:53:19 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-07-26 18:53:34 UTC) #4
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/7b2cd8b988d257f22afc7c03cd2caf8ba2e2b3a3 Cr-Commit-Position: refs/heads/master@{#38071}
4 years, 4 months ago (2016-07-26 18:55:12 UTC) #6
Camillo Bruni
4 years, 4 months ago (2016-07-27 07:44:17 UTC) #7
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2182203004/ by cbruni@chromium.org.

The reason for reverting is: Dummy initializing variables to make compilers
happy..

Powered by Google App Engine
This is Rietveld 408576698