Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1054)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: build/toolchain/win/BUILD.gn

Issue 2181073004: Roll buildtools 60f7f9a8b4..67bf0653b2 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « DEPS ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/toolchain/win/BUILD.gn
diff --git a/build/toolchain/win/BUILD.gn b/build/toolchain/win/BUILD.gn
index d4c6dd46a0cfd5314cbf4b7b6bb6effb200fd855..5e61c02082c2f8a4df40c8400c1aa1b65d57ca17 100644
--- a/build/toolchain/win/BUILD.gn
+++ b/build/toolchain/win/BUILD.gn
@@ -192,13 +192,7 @@ template("msvc_toolchain") {
]
link_output = libname
depend_output = libname
-
- # The new version of GN uses a runtime_outputs list rather than a
- # runtime_link_output string. This needs to be flipped for the next GN
- # roll.
- # TODO(brettw) bug 631242: Swap this and remove the old one.
- #runtime_outputs = [ dllname ]
- runtime_link_output = dllname
+ runtime_outputs = [ dllname ]
# Since the above commands only updates the .lib file when it changes, ask
# Ninja to check if the timestamp actually changed to know if downstream
« no previous file with comments | « DEPS ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698