Roll buildtools 60f7f9a8b4..67bf0653b2

Roll buildtools 60f7f9a8b4..67bf0653b2

  In order to roll GN 1f41736051..15e0e74f4d (r406705:r407852) and pick up
  the following changes:

  15e0e74 Allow GN toolchains to specify runtime deps outputs.

TBR=dpranke@chromium.org

Committed: https://crrev.com/48fc5f354377adc048e780a3a33232378750576b
Cr-Commit-Position: refs/heads/master@{#407890}

[brettw, 2016-07-26 18:59:13]

The CQ bit was checked by brettw@chromium.org

[commit-bot: I haz the power, 2016-07-26 18:59:51]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Dirk Pranke, 2016-07-26 19:01:58]

lgtm, though I think we probably need to update tools/gn/docs/reference.md as
well in a follow-up.

[commit-bot: I haz the power, 2016-07-26 20:04:37]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-07-26 20:06:44]

Description was changed from

==========
Roll buildtools 60f7f9a8b4..67bf0653b2

  In order to roll GN 1f41736051..15e0e74f4d (r406705:r407852) and pick up
  the following changes:

  15e0e74 Allow GN toolchains to specify runtime deps outputs.

TBR=dpranke@chromium.org
==========

to

==========
Roll buildtools 60f7f9a8b4..67bf0653b2

  In order to roll GN 1f41736051..15e0e74f4d (r406705:r407852) and pick up
  the following changes:

  15e0e74 Allow GN toolchains to specify runtime deps outputs.

TBR=dpranke@chromium.org

Committed: https://crrev.com/48fc5f354377adc048e780a3a33232378750576b
Cr-Commit-Position: refs/heads/master@{#407890}
==========

[commit-bot: I haz the power, 2016-07-26 20:06:45]

Patchset 1 (id:??) landed as
https://crrev.com/48fc5f354377adc048e780a3a33232378750576b
Cr-Commit-Position: refs/heads/master@{#407890}

[yoichio, 2016-07-27 02:18:51]

On 2016/07/26 20:06:45, commit-bot: I haz the power wrote:
> Patchset 1 (id:??) landed as
> https://crrev.com/48fc5f354377adc048e780a3a33232378750576b
> Cr-Commit-Position: refs/heads/master@{#407890}

This causes "gn gen" error on windows.

$ gn gen out_mygn
ERROR at //build/toolchain/win/BUILD.gn:195:25: Assignment had no effect.
      runtime_outputs = [ dllname ]
                        ^---------
You set the variable "runtime_outputs" here and it was unused before it went
out of scope.
See //build/toolchain/win/BUILD.gn:344:3: whence it was called.
  msvc_toolchain(target_name) {
  ^----------------------------
See //build/toolchain/win/BUILD.gn:374:1: whence it was called.
win_x64_toolchains("x64") {
^--------------------------
See //BUILD.gn:65:1: which caused the file to be included.
group("gn_all") {
^----------------
exit status 1

Could you fix it or revert?

[Dirk Pranke, 2016-07-27 04:16:03]

On 2016/07/27 02:18:51, yoichio wrote:
> On 2016/07/26 20:06:45, commit-bot: I haz the power wrote:
> > Patchset 1 (id:??) landed as
> > https://crrev.com/48fc5f354377adc048e780a3a33232378750576b
> > Cr-Commit-Position: refs/heads/master@{#407890}
> 
> This causes "gn gen" error on windows.
> 
> $ gn gen out_mygn
> ERROR at //build/toolchain/win/BUILD.gn:195:25: Assignment had no effect.
>       runtime_outputs = [ dllname ]
>                         ^---------
> You set the variable "runtime_outputs" here and it was unused before it went
> out of scope.
> See //build/toolchain/win/BUILD.gn:344:3: whence it was called.
>   msvc_toolchain(target_name) {
>   ^----------------------------
> See //build/toolchain/win/BUILD.gn:374:1: whence it was called.
> win_x64_toolchains("x64") {
> ^--------------------------
> See //BUILD.gn:65:1: which caused the file to be included.
> group("gn_all") {
> ^----------------
> exit status 1
> 
> Could you fix it or revert?

If you're getting that error, it means you don't have the latest GN binary,
which should've
been pulled in by the DEPS change. Did you re-run `gclient runhooks`?

(The bots are all green, which is why I'm suspecting a local problem on your
machine).