Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(611)

Issue 2181073002: MD WebUI: disable custom properties (Closed)

Created:
4 years, 5 months ago by Dan Beam
Modified:
4 years, 5 months ago
Reviewers:
michaelpg
CC:
chromium-reviews, oshima+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD WebUI: disable custom properties They were never on to begin with and now that we've reached a new enough version of Polymer that this flag actually has an effect, it's breaking things. TBR=michaelpg@chromium.org BUG=none CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation NOTRY=true Committed: https://crrev.com/0ea8724e1e4645025d4835a9278b0acaee22e2ed Cr-Commit-Position: refs/heads/master@{#407601}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M ui/webui/resources/js/polymer_config.js View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 12 (6 generated)
Dan Beam
4 years, 5 months ago (2016-07-25 21:28:45 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2181073002/1
4 years, 5 months ago (2016-07-25 21:50:35 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-25 21:54:21 UTC) #8
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/0ea8724e1e4645025d4835a9278b0acaee22e2ed Cr-Commit-Position: refs/heads/master@{#407601}
4 years, 5 months ago (2016-07-25 21:57:34 UTC) #10
Dan Beam
css custom properties (aka variables) **
4 years, 5 months ago (2016-07-25 23:55:25 UTC) #11
michaelpg
4 years, 5 months ago (2016-07-26 04:01:10 UTC) #12
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698