Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ChromeStrictMode.java

Issue 2181053002: android: dcheck_always_on sets BuildConfig.IS_DCHECK (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix findbugs Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/config/android/rules.gni ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/java/src/org/chromium/chrome/browser/ChromeStrictMode.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ChromeStrictMode.java b/chrome/android/java/src/org/chromium/chrome/browser/ChromeStrictMode.java
index 1fae958f387f4f51941f71a095e1ec2d41b6147d..fe841f452ae7cb260fef285afd6ae0bc9166874a 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/ChromeStrictMode.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/ChromeStrictMode.java
@@ -160,7 +160,7 @@ public class ChromeStrictMode {
*/
@UiThread
// FindBugs doesn't like conditionals with compile time results
- @SuppressFBWarnings("UCF_USELESS_CONTROL_FLOW_NEXT_LINE")
+ @SuppressFBWarnings("UCF_USELESS_CONTROL_FLOW")
public static void configureStrictMode() {
assert ThreadUtils.runningOnUiThread();
if (sIsStrictModeAlreadyConfigured) {
@@ -175,7 +175,7 @@ public class ChromeStrictMode {
CommandLine commandLine = CommandLine.getInstance();
if ("eng".equals(Build.TYPE)
- || BuildConfig.IS_DEBUG
+ || BuildConfig.DCHECK_IS_ON
|| ChromeVersionInfo.isLocalBuild()
|| commandLine.hasSwitch(ChromeSwitches.STRICT_MODE)) {
turnOnDetection(threadPolicy, vmPolicy);
@@ -195,7 +195,8 @@ public class ChromeStrictMode {
// closely monitor this on dev channel.
boolean enableStrictModeWatch =
(ChromeVersionInfo.isDevBuild() && Math.random() < UPLOAD_PROBABILITY);
- if ((ChromeVersionInfo.isLocalBuild() && !BuildConfig.IS_DEBUG) || enableStrictModeWatch) {
+ if ((ChromeVersionInfo.isLocalBuild() && !BuildConfig.DCHECK_IS_ON)
+ || enableStrictModeWatch) {
turnOnDetection(threadPolicy, vmPolicy);
initializeStrictModeWatch();
}
« no previous file with comments | « build/config/android/rules.gni ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698