Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(337)

Side by Side Diff: base/BUILD.gn

Issue 2181053002: android: dcheck_always_on sets BuildConfig.IS_DCHECK (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix findbugs Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | base/android/java/src/org/chromium/base/BaseChromiumApplication.java » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 # HOW TO WRITE CONDITIONALS IN THIS FILE 5 # HOW TO WRITE CONDITIONALS IN THIS FILE
6 # ====================================== 6 # ======================================
7 # 7 #
8 # In many other places, one would write a conditional that expresses all the 8 # In many other places, one would write a conditional that expresses all the
9 # cases when a source file is used or unused, and then either add or subtract 9 # cases when a source file is used or unused, and then either add or subtract
10 # it from the sources list in that case 10 # it from the sources list in that case
11 # 11 #
12 # Since base includes so many low-level things that vary widely and 12 # Since base includes so many low-level things that vary widely and
13 # unpredictably for the various build types, we prefer a slightly different 13 # unpredictably for the various build types, we prefer a slightly different
14 # style. Instead, there are big per-platform blocks of inclusions and 14 # style. Instead, there are big per-platform blocks of inclusions and
15 # exclusions. If a given file has an inclusion or exclusion rule that applies 15 # exclusions. If a given file has an inclusion or exclusion rule that applies
16 # for multiple conditions, perfer to duplicate it in both lists. This makes it 16 # for multiple conditions, perfer to duplicate it in both lists. This makes it
17 # a bit easier to see which files apply in which cases rather than having a 17 # a bit easier to see which files apply in which cases rather than having a
18 # huge sequence of random-looking conditionals. 18 # huge sequence of random-looking conditionals.
19 19
20 import("//build/buildflag_header.gni") 20 import("//build/buildflag_header.gni")
21 import("//build/config/allocator.gni") 21 import("//build/config/allocator.gni")
22 import("//build/config/chromecast_build.gni") 22 import("//build/config/chromecast_build.gni")
23 import("//build/config/compiler/compiler.gni") 23 import("//build/config/compiler/compiler.gni")
24 import("//build/config/dcheck_always_on.gni")
24 import("//build/config/nacl/config.gni") 25 import("//build/config/nacl/config.gni")
25 import("//build/config/sysroot.gni") 26 import("//build/config/sysroot.gni")
26 import("//build/config/ui.gni") 27 import("//build/config/ui.gni")
27 import("//build/nocompile.gni") 28 import("//build/nocompile.gni")
28 import("//testing/test.gni") 29 import("//testing/test.gni")
29 30
30 declare_args() { 31 declare_args() {
31 # Override this value to give a specific build date. 32 # Override this value to give a specific build date.
32 # See //base/build_time.cc and //build/write_build_date_header.py for more 33 # See //base/build_time.cc and //build/write_build_date_header.py for more
33 # details and the expected format. 34 # details and the expected format.
(...skipping 2380 matching lines...) Expand 10 before | Expand all | Expand 10 after
2414 } 2415 }
2415 2416
2416 # GYP: //base/base.gyp:base_build_config_gen 2417 # GYP: //base/base.gyp:base_build_config_gen
2417 java_cpp_template("base_build_config_gen") { 2418 java_cpp_template("base_build_config_gen") {
2418 sources = [ 2419 sources = [
2419 "android/java/templates/BuildConfig.template", 2420 "android/java/templates/BuildConfig.template",
2420 ] 2421 ]
2421 package_name = "org/chromium/base" 2422 package_name = "org/chromium/base"
2422 2423
2423 defines = [] 2424 defines = []
2424 if (!is_java_debug) { 2425 if (is_java_debug || dcheck_always_on) {
2425 defines += [ "NDEBUG" ] 2426 defines += [ "_DCHECK_IS_ON" ]
2426 } 2427 }
2427 } 2428 }
2428 2429
2429 # GYP: //base/base.gyp:base_native_libraries_gen 2430 # GYP: //base/base.gyp:base_native_libraries_gen
2430 java_cpp_template("base_native_libraries_gen") { 2431 java_cpp_template("base_native_libraries_gen") {
2431 sources = [ 2432 sources = [
2432 "android/java/templates/NativeLibraries.template", 2433 "android/java/templates/NativeLibraries.template",
2433 ] 2434 ]
2434 package_name = "org/chromium/base/library_loader" 2435 package_name = "org/chromium/base/library_loader"
2435 } 2436 }
2436 2437
2437 # GYP: //base.gyp:base_java_unittest_support 2438 # GYP: //base.gyp:base_java_unittest_support
2438 android_library("base_java_unittest_support") { 2439 android_library("base_java_unittest_support") {
2439 deps = [ 2440 deps = [
2440 ":base_java", 2441 ":base_java",
2441 ] 2442 ]
2442 java_files = 2443 java_files =
2443 [ "test/android/java/src/org/chromium/base/ContentUriTestUtils.java" ] 2444 [ "test/android/java/src/org/chromium/base/ContentUriTestUtils.java" ]
2444 } 2445 }
2445 } 2446 }
OLDNEW
« no previous file with comments | « no previous file | base/android/java/src/org/chromium/base/BaseChromiumApplication.java » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698