Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(161)

Unified Diff: remoting/host/BUILD.gn

Issue 2181043003: Fix GN build on mac with icu_use_data_file = false (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: move (public)_deps inside if-icu_use_data_file Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/shell/BUILD.gn ('k') | remoting/host/it2me/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: remoting/host/BUILD.gn
diff --git a/remoting/host/BUILD.gn b/remoting/host/BUILD.gn
index 0df1ea9efbdf2528e3730c5a86225c1651a137f2..648333ca5c1b8724f2d1bd9f0b24aae00014e0f6 100644
--- a/remoting/host/BUILD.gn
+++ b/remoting/host/BUILD.gn
@@ -26,6 +26,7 @@ if (is_win) {
import("//remoting/host/predefines_win.gni")
} else if (is_mac) {
import("//build/config/mac/rules.gni")
+ import("//third_party/icu/config.gni")
}
# Reference this manifest to indicate that a process is per-monitor DPI aware.
@@ -976,7 +977,6 @@ if (enable_me2me_host) {
bundle_data("remoting_host_resources") {
sources = [
"$root_gen_dir/remoting/CREDITS.txt",
- "$root_out_dir/icudtl.dat",
"remoting_me2me_host.icns",
]
@@ -986,8 +986,12 @@ if (enable_me2me_host) {
public_deps = [
":credits",
- "//third_party/icu:icudata",
]
+
+ if (icu_use_data_file) {
+ sources += [ "$root_out_dir/icudtl.dat" ]
+ public_deps += [ "//third_party/icu:icudata" ]
+ }
}
}
« no previous file with comments | « content/shell/BUILD.gn ('k') | remoting/host/it2me/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698