Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(782)

Unified Diff: remoting/host/BUILD.gn

Issue 2181043003: Fix GN build on mac with icu_use_data_file = false (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: remoting/host/BUILD.gn
diff --git a/remoting/host/BUILD.gn b/remoting/host/BUILD.gn
index 720e4594b0dd176685fbf45130b814e109e3762c..cfa6b269b1d77dc625378db02f1d72b2f626ba6a 100644
--- a/remoting/host/BUILD.gn
+++ b/remoting/host/BUILD.gn
@@ -26,6 +26,7 @@ if (is_win) {
import("//remoting/host/predefines_win.gni")
} else if (is_mac) {
import("//build/config/mac/rules.gni")
+ import("//third_party/icu/config.gni")
}
# Reference this manifest to indicate that a process is per-monitor DPI aware.
@@ -976,10 +977,13 @@ if (enable_me2me_host) {
bundle_data("remoting_host_resources") {
sources = [
"$root_gen_dir/remoting/CREDITS.txt",
- "$root_out_dir/icudtl.dat",
"remoting_me2me_host.icns",
]
+ if (icu_use_data_file) {
+ sources += [ "$root_out_dir/icudtl.dat" ]
+ }
+
outputs = [
"{{bundle_resources_dir}}/{{source_file_part}}",
]

Powered by Google App Engine
This is Rietveld 408576698