Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Side by Side Diff: remoting/host/BUILD.gn

Issue 2181043003: Fix GN build on mac with icu_use_data_file = false (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: move (public)_deps inside if-icu_use_data_file Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « content/shell/BUILD.gn ('k') | remoting/host/it2me/BUILD.gn » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//build/config/features.gni") 5 import("//build/config/features.gni")
6 import("//build/config/ui.gni") 6 import("//build/config/ui.gni")
7 import("//build/config/win/manifest.gni") 7 import("//build/config/win/manifest.gni")
8 import("//build/util/version.gni") 8 import("//build/util/version.gni")
9 import("//chrome/version.gni") 9 import("//chrome/version.gni")
10 import("//remoting/remoting_enable.gni") 10 import("//remoting/remoting_enable.gni")
11 import("//remoting/remoting_locales.gni") 11 import("//remoting/remoting_locales.gni")
12 import("//remoting/remoting_options.gni") 12 import("//remoting/remoting_options.gni")
13 import("//remoting/remoting_srcs.gni") 13 import("//remoting/remoting_srcs.gni")
14 import("//remoting/remoting_version.gni") 14 import("//remoting/remoting_version.gni")
15 import("//remoting/tools/build/remoting_localize.gni") 15 import("//remoting/tools/build/remoting_localize.gni")
16 16
17 process_version("remoting_version") { 17 process_version("remoting_version") {
18 template_file = "//remoting/host/version.h.in" 18 template_file = "//remoting/host/version.h.in"
19 sources = [ 19 sources = [
20 branding_path, 20 branding_path,
21 ] 21 ]
22 output = "$target_gen_dir/version.h" 22 output = "$target_gen_dir/version.h"
23 } 23 }
24 24
25 if (is_win) { 25 if (is_win) {
26 import("//remoting/host/predefines_win.gni") 26 import("//remoting/host/predefines_win.gni")
27 } else if (is_mac) { 27 } else if (is_mac) {
28 import("//build/config/mac/rules.gni") 28 import("//build/config/mac/rules.gni")
29 import("//third_party/icu/config.gni")
29 } 30 }
30 31
31 # Reference this manifest to indicate that a process is per-monitor DPI aware. 32 # Reference this manifest to indicate that a process is per-monitor DPI aware.
32 dpi_aware_manifest = "//remoting/host/win/dpi_aware.manifest" 33 dpi_aware_manifest = "//remoting/host/win/dpi_aware.manifest"
33 34
34 # Depending on this target gives a default executable manifest with the addition 35 # Depending on this target gives a default executable manifest with the addition
35 # of the DPI aware tag. 36 # of the DPI aware tag.
36 windows_manifest("dpi_aware_exe_manifest") { 37 windows_manifest("dpi_aware_exe_manifest") {
37 sources = [ 38 sources = [
38 as_invoker_manifest, 39 as_invoker_manifest,
(...skipping 930 matching lines...) Expand 10 before | Expand all | Expand 10 after
969 970
970 mac_xib_bundle_data("remoting_host_xibs") { 971 mac_xib_bundle_data("remoting_host_xibs") {
971 sources = [ 972 sources = [
972 "disconnect_window.xib", 973 "disconnect_window.xib",
973 ] 974 ]
974 } 975 }
975 976
976 bundle_data("remoting_host_resources") { 977 bundle_data("remoting_host_resources") {
977 sources = [ 978 sources = [
978 "$root_gen_dir/remoting/CREDITS.txt", 979 "$root_gen_dir/remoting/CREDITS.txt",
979 "$root_out_dir/icudtl.dat",
980 "remoting_me2me_host.icns", 980 "remoting_me2me_host.icns",
981 ] 981 ]
982 982
983 outputs = [ 983 outputs = [
984 "{{bundle_resources_dir}}/{{source_file_part}}", 984 "{{bundle_resources_dir}}/{{source_file_part}}",
985 ] 985 ]
986 986
987 public_deps = [ 987 public_deps = [
988 ":credits", 988 ":credits",
989 "//third_party/icu:icudata",
990 ] 989 ]
990
991 if (icu_use_data_file) {
992 sources += [ "$root_out_dir/icudtl.dat" ]
993 public_deps += [ "//third_party/icu:icudata" ]
994 }
991 } 995 }
992 } 996 }
993 997
994 target(app_target_type, "remoting_me2me_host") { 998 target(app_target_type, "remoting_me2me_host") {
995 if (is_mac) { 999 if (is_mac) {
996 extra_configs = [ "//remoting:version" ] 1000 extra_configs = [ "//remoting:version" ]
997 info_plist = "remoting_me2me_host-Info.plist" 1001 info_plist = "remoting_me2me_host-Info.plist"
998 extra_substitutions = [ 1002 extra_substitutions = [
999 "BUNDLE_ID=$host_bundle_id", 1003 "BUNDLE_ID=$host_bundle_id",
1000 "VERSION_FULL=$remoting_version_full", 1004 "VERSION_FULL=$remoting_version_full",
(...skipping 630 matching lines...) Expand 10 before | Expand all | Expand 10 after
1631 root_build_dir), 1635 root_build_dir),
1632 rebase_path(outputs[0], root_build_dir), 1636 rebase_path(outputs[0], root_build_dir),
1633 ] 1637 ]
1634 } 1638 }
1635 } else { 1639 } else {
1636 group("remoting_host_installation") { 1640 group("remoting_host_installation") {
1637 } 1641 }
1638 } 1642 }
1639 } 1643 }
1640 } 1644 }
OLDNEW
« no previous file with comments | « content/shell/BUILD.gn ('k') | remoting/host/it2me/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698