Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(212)

Side by Side Diff: remoting/host/it2me/BUILD.gn

Issue 2181043003: Fix GN build on mac with icu_use_data_file = false (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« content/shell/BUILD.gn ('K') | « remoting/host/BUILD.gn ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//build/config/features.gni") 5 import("//build/config/features.gni")
6 import("//remoting/remoting_enable.gni") 6 import("//remoting/remoting_enable.gni")
7 import("//remoting/remoting_srcs.gni") 7 import("//remoting/remoting_srcs.gni")
8 import("//remoting/remoting_locales.gni") 8 import("//remoting/remoting_locales.gni")
9 9
10 if (is_win) { 10 if (is_win) {
11 import("//remoting/host/predefines_win.gni") 11 import("//remoting/host/predefines_win.gni")
12 } 12 }
13 if (is_mac) { 13 if (is_mac) {
14 import("//build/config/mac/rules.gni") 14 import("//build/config/mac/rules.gni")
15 import("//third_party/icu/config.gni")
15 } 16 }
16 17
17 source_set("common") { 18 source_set("common") {
18 sources = rebase_path( 19 sources = rebase_path(
19 remoting_host_srcs_gypi_values.remoting_it2me_host_static_sources, 20 remoting_host_srcs_gypi_values.remoting_it2me_host_static_sources,
20 ".", 21 ".",
21 "//remoting") 22 "//remoting")
22 23
23 if (is_android) { 24 if (is_android) {
24 sources -= [ 25 sources -= [
(...skipping 67 matching lines...) Expand 10 before | Expand all | Expand 10 after
92 ] 93 ]
93 } 94 }
94 } 95 }
95 96
96 mac_xib_bundle_data("remote_assistance_host_xibs") { 97 mac_xib_bundle_data("remote_assistance_host_xibs") {
97 sources = [ 98 sources = [
98 "//remoting/host/disconnect_window.xib", 99 "//remoting/host/disconnect_window.xib",
99 ] 100 ]
100 } 101 }
101 102
102 bundle_data("remote_assistance_host_resources") { 103 if (icu_use_data_file) {
103 sources = [ 104 bundle_data("remote_assistance_host_resources") {
104 "$root_out_dir/icudtl.dat", 105 sources = [
105 ] 106 "$root_out_dir/icudtl.dat",
107 ]
106 108
107 outputs = [ 109 outputs = [
108 "{{bundle_resources_dir}}/{{source_file_part}}", 110 "{{bundle_resources_dir}}/{{source_file_part}}",
109 ] 111 ]
110 112
111 public_deps = [ 113 public_deps = [
112 "//third_party/icu:icudata", 114 "//third_party/icu:icudata",
113 ] 115 ]
116 }
114 } 117 }
115 } else { 118 } else {
116 app_target_type = "executable" 119 app_target_type = "executable"
117 } 120 }
118 121
119 target(app_target_type, "remote_assistance_host") { 122 target(app_target_type, "remote_assistance_host") {
120 if (is_mac) { 123 if (is_mac) {
121 info_plist = "remote_assistance_host-Info.plist" 124 info_plist = "remote_assistance_host-Info.plist"
122 extra_configs = [ 125 extra_configs = [
123 "//build/config/compiler:wexit_time_destructors", 126 "//build/config/compiler:wexit_time_destructors",
(...skipping 21 matching lines...) Expand all
145 "//ui/gfx", 148 "//ui/gfx",
146 ] 149 ]
147 if (is_mac) { 150 if (is_mac) {
148 foreach(locale, remoting_locales_with_underscores) { 151 foreach(locale, remoting_locales_with_underscores) {
149 deps += [ 152 deps += [
150 ":remote_assistance_host_strings_${locale}_bundle_data", 153 ":remote_assistance_host_strings_${locale}_bundle_data",
151 "//remoting/host:remoting_host_locale_${locale}_bundle_data", 154 "//remoting/host:remoting_host_locale_${locale}_bundle_data",
152 ] 155 ]
153 } 156 }
154 deps += [ 157 deps += [
155 ":remote_assistance_host_resources",
156 ":remote_assistance_host_xibs", 158 ":remote_assistance_host_xibs",
157 "//remoting/host:remoting_infoplist_strings", 159 "//remoting/host:remoting_infoplist_strings",
158 "//remoting/resources:copy_locales", 160 "//remoting/resources:copy_locales",
159 ] 161 ]
162 if (icu_use_data_file) {
163 deps += [ ":remote_assistance_host_resources" ]
164 }
160 } 165 }
161 166
162 if (enable_webrtc) { 167 if (enable_webrtc) {
163 deps += [ "//third_party/libjingle:libjingle_webrtc" ] 168 deps += [ "//third_party/libjingle:libjingle_webrtc" ]
164 } 169 }
165 170
166 if (is_desktop_linux) { 171 if (is_desktop_linux) {
167 deps += [ "//build/config/linux/gtk2" ] 172 deps += [ "//build/config/linux/gtk2" ]
168 } 173 }
169 } 174 }
170 } 175 }
171 } 176 }
OLDNEW
« content/shell/BUILD.gn ('K') | « remoting/host/BUILD.gn ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698