Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issue 2181033002: Have SkRasterPipelineBlitter take over for F16 when it can. (Closed)

Created:
4 years, 4 months ago by mtklein_C
Modified:
4 years, 4 months ago
Reviewers:
Brian Osman, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Have SkRasterPipelineBlitter take over for F16 when it can. 3 minor diffs to a couple GMs from fixed transfermodes (arithmetic and plus). BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2181033002 Committed: https://skia.googlesource.com/skia/+/4e90e3eb5e43ffa8f347570578f5a538793b0cc7

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+65 lines, -5 lines) Patch
M src/core/SkRasterPipelineBlitter.cpp View 6 chunks +65 lines, -5 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
mtklein_C
4 years, 4 months ago (2016-07-25 20:09:05 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2181033002/1
4 years, 4 months ago (2016-07-25 20:09:16 UTC) #5
mtklein_C
+Mike
4 years, 4 months ago (2016-07-25 21:27:35 UTC) #7
reed1
seems like we might already have a nanobench for some of these cases. Have we ...
4 years, 4 months ago (2016-07-25 21:34:01 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://skia.googlesource.com/skia/+/4e90e3eb5e43ffa8f347570578f5a538793b0cc7
4 years, 4 months ago (2016-07-25 21:35:34 UTC) #10
mtklein
4 years, 4 months ago (2016-07-25 21:42:51 UTC) #11
Message was sent while issue was closed.
On 2016/07/25 21:34:01, reed1 wrote:
> seems like we might already have a nanobench for some of these cases. Have we
> looked at the perf comparison?
> 
> code-change is nice. lgtm

Yeah, it's on my radar to make sure I've got a good handle on how perf is
changing.
We do already for 565 (which of course got slower now that we're taking it up to
float and back).

Powered by Google App Engine
This is Rietveld 408576698